From 510410e81c0bc50f7e4880146bd87eba446d6134 Mon Sep 17 00:00:00 2001
From: Elliot Winkler <elliot.winkler@gmail.com>
Date: Wed, 9 Sep 2026 09:00:42 -0600
Subject: [PATCH] Fix dev-only lint errors in product-safety packages

Currently, there are some type errors that exist in packages owned by
`@MetaMask/product-safety`. These type errors are not present in
production code, so they are not flagged by `yarn build`, but they
_will_ be flagged soon by `yarn lint:tsc`, and so we need to fix them.
---
 .../src/PhishingController.test.ts            | 25 +++++++++++--------
 .../phishing-controller/src/tests/utils.ts    |  1 +
 2 files changed, 16 insertions(+), 10 deletions(-)

diff --git a/packages/phishing-controller/src/PhishingController.test.ts b/packages/phishing-controller/src/PhishingController.test.ts
index c65249daa57..776f1d6fbd0 100644
--- a/packages/phishing-controller/src/PhishingController.test.ts
+++ b/packages/phishing-controller/src/PhishingController.test.ts
@@ -76,6 +76,7 @@ function getDefaultTransactionControllerState(): TransactionControllerState {
   return {
     transactions: [],
     transactionBatches: [],
+    batchTransactionCounts: {},
     methodData: {},
     lastFetchedBlockNumbers: {},
     submitHistory: [],
@@ -4837,19 +4838,23 @@ describe('Address poisoning detection', () => {
       [],
     );
 
-    rootMessenger.publish('AddressBookController:stateChange', {
-      addressBook: {
-        '0x1': {
-          [ADDRESS_BOOK_RECIPIENT]: {
-            address: ADDRESS_BOOK_RECIPIENT,
-            name: 'Known recipient',
-            chainId: '0x1',
-            memo: '',
-            isEns: false,
+    rootMessenger.publish(
+      'AddressBookController:stateChange',
+      {
+        addressBook: {
+          '0x1': {
+            [ADDRESS_BOOK_RECIPIENT]: {
+              address: ADDRESS_BOOK_RECIPIENT,
+              name: 'Known recipient',
+              chainId: '0x1',
+              memo: '',
+              isEns: false,
+            },
           },
         },
       },
-    });
+      [],
+    );
 
     await new Promise((resolve) => process.nextTick(resolve));
 
diff --git a/packages/phishing-controller/src/tests/utils.ts b/packages/phishing-controller/src/tests/utils.ts
index c1b6f3833ff..ff6892b9a15 100644
--- a/packages/phishing-controller/src/tests/utils.ts
+++ b/packages/phishing-controller/src/tests/utils.ts
@@ -116,6 +116,7 @@ export const createMockStateChangePayload = (
 ) => ({
   transactions,
   transactionBatches: [],
+  batchTransactionCounts: {},
   methodData: {},
   lastFetchedBlockNumbers: {},
   submitHistory: [],