Skip to content

Commit 8dde86d

Browse files
committed
ci: install setuptools directly instead of via extra-build-dependencies
uv pip install did not pick up [tool.uv.extra-build-dependencies] (same "No module named 'setuptools'" error, with the same hint, reappeared on the next run) - that config apparently only applies to uv's project-aware resolver (uv sync/lock), not the pip-compatible uv pip install used here. Installing setuptools into the venv directly before the --no-build-isolation gdal build is the other fix uv's error suggested, and doesn't depend on that.
1 parent 0a3a147 commit 8dde86d

2 files changed

Lines changed: 1 addition & 7 deletions

File tree

‎.github/workflows/packages.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ jobs:
106106
run: |
107107
uv sync --package map2loop --extra tests --python ${{ matrix.python-version }}
108108
GDAL_VERSION=$(gdal-config --version)
109+
uv pip install setuptools
109110
uv pip install "gdal==${GDAL_VERSION}" --no-build-isolation-package gdal
110111
111112
- name: pytest

‎pyproject.toml‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -94,13 +94,6 @@ loopstructuralvisualisation = { workspace = true }
9494
map2loop = { workspace = true }
9595
LoopStructural = { workspace = true }
9696

97-
[tool.uv.extra-build-dependencies]
98-
# gdal is installed with --no-build-isolation-package (see packages.yml) so
99-
# its setup.py can see the venv's numpy and build the _gdal_array extension;
100-
# that also means it no longer gets setuptools for free from an isolated
101-
# build env, so it must be declared here.
102-
gdal = ["setuptools"]
103-
10497
[tool.pytest.ini_options]
10598
addopts = "--import-mode=importlib"
10699
testpaths = ["tests"]

0 commit comments

Comments
 (0)