refactor: streamline Redis integration and remove microservice queue adapter

- Removed the deprecated microservice queue adapter and related interfaces to simplify the codebase.
- Updated Redis connection handling in the BullMQ adapter to utilize a more reliable options parsing method.
- Refactored the SESAME_MS_BETA configuration handling, removing unnecessary complexity from the queue module.
- Enhanced the lifecycle hooks service to skip unnecessary lifecycle events for operational state changes.
- Improved the identity search functionality by integrating dynamic search fields and updating related components.
- Updated Nuxt.js configuration to support new WebSocket proxy settings and loading bar defaults.

Author: tacxou

apps/api/.env.example

@@ -1,6 +1,5 @@
 # SESAME_LOG_LEVEL="info"
 # SESAME_NAME_QUEUE="sesame"
-# SESAME_MS_BETA=1
 SESAME_JWT_SECRET="zeaezazeaezazaeeazrftrqezfqfqszewfsqddfqsqsqsdqdsqdsqdzsdqzsdqzs"
 # Docker (make dev) : hostname du conteneur Redis sur le réseau dev
 SESAME_REDIS_URI="redis://sesame-redis:6379/0"

apps/api/package.json

@@ -28,7 +28,6 @@
     "@nestjs/core": "^10.4.8",
     "@nestjs/event-emitter": "^3.0.1",
     "@nestjs/jwt": "^10.2.0",
-    "@nestjs/microservices": "^10.4.16",
     "@nestjs/mongoose": "^10.1.0",
     "@nestjs/passport": "^10.0.3",
     "@nestjs/platform-express": "^10.4.8",

apps/api/src/_common/functions/redis-options-from-uri.ts

@@ -1,14 +1,8 @@
 import { RedisOptions } from 'ioredis';
 
-/** Options NestJS Redis transport (ioredis + retryAttempts/retryDelay). */
-export type RedisMicroserviceTransportOptions = RedisOptions & {
-  retryAttempts?: number;
-  retryDelay?: number;
-};
-
 /**
  * Convertit SESAME_REDIS_URI en options ioredis (host/port/db) pour le transport Redis NestJS.
- * Plus fiable que `url` seul avec ClientsModule / createMicroservice.
+ * Plus fiable que `url` seul.
  */
 export function redisOptionsFromUri(uri: string, extra?: RedisOptions): RedisOptions {
   const parsed = new URL(uri);
@@ -24,16 +18,3 @@ export function redisOptionsFromUri(uri: string, extra?: RedisOptions): RedisOpt
     ...extra,
   };
 }
-
-/** Options recommandées pour @nestjs/microservices (pub/sub Redis). */
-export function redisMicroserviceTransportOptions(uri: string): RedisMicroserviceTransportOptions {
-  return {
-    ...redisOptionsFromUri(uri, {
-      maxRetriesPerRequest: null,
-      enableReadyCheck: true,
-      lazyConnect: false,
-    }),
-    retryAttempts: 0,
-    retryDelay: 0,
-  };
-}

apps/api/src/_common/interfaces/sesame-job-event.interface.ts

@@ -42,6 +42,7 @@ export class BullmqQueueAdapter implements SesameQueueAdapter {
 
     this._queue = new Queue(queueName, { connection });
     this._queueEvents = new QueueEvents(queueName, { connection });
+    await this._queueEvents.waitUntilReady();
     this._eventsEmitter = new BullmqQueueEventsEmitter(this._queueEvents);
     this._logger.log(`BullMQ queue "${queueName}" ready`);
   }

apps/api/src/_common/queue/bullmq-queue.adapter.ts

@@ -1,2 +1 @@
 export const SESAME_QUEUE = Symbol('SESAME_QUEUE');
-export const SESAME_DAEMON_CLIENT = 'SESAME_DAEMON';

apps/api/src/_common/queue/microservice-queue.adapter.ts

@@ -1,53 +1,26 @@
-import { DynamicModule, Global, Module } from '@nestjs/common';
-import { ConfigModule, ConfigService } from '@nestjs/config';
-import { ClientsModule, Transport } from '@nestjs/microservices';
-import { getRedisConnectionToken } from '@nestjs-modules/ioredis';
-import Redis from 'ioredis';
-import { redisMicroserviceTransportOptions } from '~/_common/functions/redis-options-from-uri';
-import { BullmqQueueAdapter } from './bullmq-queue.adapter';
-import { MicroserviceQueueAdapter } from './microservice-queue.adapter';
-import { SESAME_DAEMON_CLIENT, SESAME_QUEUE } from './sesame-queue.constants';
-import { SesameQueueAdapter } from '~/_common/interfaces/sesame-job.interface';
-import { ClientProxy } from '@nestjs/microservices';
+import { DynamicModule, Global, Module } from '@nestjs/common'
+import { ConfigModule, ConfigService } from '@nestjs/config'
+import { getRedisConnectionToken } from '@nestjs-modules/ioredis'
+import Redis from 'ioredis'
+import { BullmqQueueAdapter } from './bullmq-queue.adapter'
+import { SESAME_QUEUE } from './sesame-queue.constants'
+import { SesameQueueAdapter } from '~/_common/interfaces/sesame-job.interface'
 
 @Global()
 @Module({})
 export class SesameQueueModule {
   public static register(): DynamicModule {
-    const msBeta = process.env['SESAME_MS_BETA'] === '1';
-
     return {
       module: SesameQueueModule,
-      imports: msBeta
-        ? [
-            ClientsModule.registerAsync([
-              {
-                name: SESAME_DAEMON_CLIENT,
-                imports: [ConfigModule],
-                inject: [ConfigService],
-                useFactory: (config: ConfigService) => ({
-                  transport: Transport.REDIS,
-                  options: redisMicroserviceTransportOptions(config.get<string>('ioredis.uri')),
-                }),
-              },
-            ]),
-          ]
-        : [],
+      imports: [ConfigModule],
       providers: [
         {
           provide: SESAME_QUEUE,
-          useFactory: (config: ConfigService, redis: Redis, client?: ClientProxy): SesameQueueAdapter => {
-            if (msBeta) {
-              return new MicroserviceQueueAdapter(client, config);
-            }
-            return new BullmqQueueAdapter(redis, config);
-          },
-          inject: msBeta
-            ? [ConfigService, getRedisConnectionToken(), SESAME_DAEMON_CLIENT]
-            : [ConfigService, getRedisConnectionToken()],
+          useFactory: (config: ConfigService, redis: Redis): SesameQueueAdapter => new BullmqQueueAdapter(redis, config),
+          inject: [ConfigService, getRedisConnectionToken()],
         },
       ],
       exports: [SESAME_QUEUE],
-    };
+    }
   }
 }

apps/api/src/_common/queue/sesame-queue.constants.ts

@@ -9,6 +9,7 @@ import { MongooseModule, MongooseModuleOptions } from '@nestjs/mongoose';
 import mongoose from 'mongoose';
 import { RedisModule } from '@nestjs-modules/ioredis';
 import { RedisOptions } from 'ioredis';
+import { redisOptionsFromUri } from '~/_common/functions/redis-options-from-uri';
 import { AppController } from './app.controller';
 import { AppService } from './app.service';
 import { RequestContextModule } from 'nestjs-request-context';
@@ -115,21 +116,25 @@ import { MfaGuard } from './_common/guards/mfa.guard';
         options: config.get<RedisOptions>('ioredis.options'),
       }),
     }),
-    ...(process.env['SESAME_MS_BETA'] !== '1'
-      ? [
-          BullModule.forRootAsync({
-            imports: [ConfigModule],
-            inject: [ConfigService],
-            useFactory: async (configService: ConfigService) => ({
-              connection: {
-                host: configService.get('ioredis.host'),
-                port: configService.get('ioredis.port'),
-              },
-              blockingConnection: true,
-            }),
-          }),
-        ]
-      : []),
+    BullModule.forRootAsync({
+      imports: [ConfigModule],
+      inject: [ConfigService],
+      useFactory: async (configService: ConfigService) => {
+        const uri = configService.get<string>('ioredis.uri')
+        const redisOptions = redisOptionsFromUri(uri)
+
+        return {
+          connection: {
+            host: redisOptions.host,
+            port: redisOptions.port,
+            ...(redisOptions.username ? { username: redisOptions.username } : {}),
+            ...(redisOptions.password ? { password: redisOptions.password } : {}),
+            ...(typeof redisOptions.db === 'number' ? { db: redisOptions.db } : {}),
+          },
+          blockingConnection: true,
+        }
+      },
+    }),
     SesameQueueModule.register(),
     AccessControlModule.forRootAsync({
       imports: [CoreModule],

apps/api/src/_common/queue/sesame-queue.module.ts

@@ -44,11 +44,6 @@ export const validationSchema = Joi.object({
     .string()
     .default('sesame'),
 
-  SESAME_MS_BETA: Joi
-    .string()
-    .valid('0', '1')
-    .default('0'),
-
   SESAME_HTTPS_ENABLED: Joi
     .string()
     .valid('0', '1', 'true', 'false', 'on', 'off')
@@ -215,8 +210,6 @@ export interface ConfigInstance {
     lang: string
     logLevel: string
     nameQueue: string
-    /** Transport Redis microservice NestJS (remplace BullMQ côté API/daemon). */
-    msBeta: boolean
     /** Si true, Express applique trust proxy (1 hop) pour les adresses IP client derrière un proxy. */
     trustProxy: boolean
     bodyParser: {
@@ -318,7 +311,6 @@ export default (): ConfigInstance => ({
     lang: process.env['LANG'] || 'en',
     logLevel: process.env['SESAME_LOG_LEVEL'] || 'info',
     nameQueue: process.env['SESAME_NAME_QUEUE'] || 'sesame',
-    msBeta: process.env['SESAME_MS_BETA'] === '1',
     trustProxy: /^(1|true|on|yes)$/i.test(process.env['SESAME_TRUST_PROXY'] || ''),
     bodyParser: {
       limit: '500mb',