From a4298e1efe32e7eda63b544b39d8e72227682bf2 Mon Sep 17 00:00:00 2001 From: Lucas Bedatty Date: Mon, 13 Jul 2026 22:57:14 -0300 Subject: [PATCH 1/2] fix(ungoliant): bump curl-timeout default from 300s to 900s MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit midaz's release-diff timed out at exactly 300s (github.com/LerianStudio/midaz/actions/runs/29279206313) — its diff is large/complex enough that inference + schema validation exceeds the previous default. Bumped alongside ungoliant-controller's NEMOCLAW_TIMEOUT_SECONDS and its ingress proxy timeouts (both moved to 900/960s in lerian-internal-gitops), which this value must stay in lockstep with — a client-side timeout shorter than the controller's own budget fails the CI job even when the controller would have eventually succeeded. --- src/validate/ungoliant-release-diff/README.md | 2 +- src/validate/ungoliant-release-diff/action.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/validate/ungoliant-release-diff/README.md b/src/validate/ungoliant-release-diff/README.md index 25a69d0d..92cc0626 100644 --- a/src/validate/ungoliant-release-diff/README.md +++ b/src/validate/ungoliant-release-diff/README.md @@ -34,7 +34,7 @@ This is the CI equivalent of `ungoliant-controller/docs/testing/cluster/test-rel | `github-token` | GitHub token used to read tags, compare and diff via the API. | Yes | | | `webhook-token` | Ungoliant webhook token sent as the `X-Ungoliant-Token` header. | No | `""` | | `max-diff-bytes` | Maximum diff size forwarded to the controller (bytes). | No | `262144` | -| `curl-timeout` | Timeout for the webhook POST in seconds. | No | `300` | +| `curl-timeout` | Timeout for the webhook POST in seconds. | No | `900` | | `dry-run` | Resolve and preview the payload without firing the webhook. | No | `false` | ## Outputs diff --git a/src/validate/ungoliant-release-diff/action.yml b/src/validate/ungoliant-release-diff/action.yml index 14776e6d..b4968126 100644 --- a/src/validate/ungoliant-release-diff/action.yml +++ b/src/validate/ungoliant-release-diff/action.yml @@ -48,9 +48,9 @@ inputs: required: false default: "262144" curl-timeout: - description: Timeout for the webhook POST in seconds (LLM inference can take 60-120s) + description: Timeout for the webhook POST in seconds (LLM inference can take 60-120s, longer for large/complex diffs). Must stay in lockstep with ungoliant-controller's NEMOCLAW_TIMEOUT_SECONDS and its ingress proxy timeouts. required: false - default: "300" + default: "900" dry-run: description: Resolve and preview the payload without firing the webhook required: false From ccef62e2190b2bb88a35fde44e27b5c95ed5095b Mon Sep 17 00:00:00 2001 From: Lucas Bedatty Date: Mon, 13 Jul 2026 23:09:14 -0300 Subject: [PATCH 2/2] docs(ungoliant): document curl-timeout lockstep requirement in README MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit action.yml's own input description already states this must stay aligned with ungoliant-controller's NEMOCLAW_TIMEOUT_SECONDS and its ingress proxy timeouts, but the README table only showed the bare number — a README-only reader could plausibly bump curl-timeout alone without knowing the other two must move with it. Addresses CodeRabbit review comment on PR #571. --- src/validate/ungoliant-release-diff/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/validate/ungoliant-release-diff/README.md b/src/validate/ungoliant-release-diff/README.md index 92cc0626..167cd7e8 100644 --- a/src/validate/ungoliant-release-diff/README.md +++ b/src/validate/ungoliant-release-diff/README.md @@ -34,7 +34,7 @@ This is the CI equivalent of `ungoliant-controller/docs/testing/cluster/test-rel | `github-token` | GitHub token used to read tags, compare and diff via the API. | Yes | | | `webhook-token` | Ungoliant webhook token sent as the `X-Ungoliant-Token` header. | No | `""` | | `max-diff-bytes` | Maximum diff size forwarded to the controller (bytes). | No | `262144` | -| `curl-timeout` | Timeout for the webhook POST in seconds. | No | `900` | +| `curl-timeout` | Timeout for the webhook POST in seconds. Must stay in lockstep with `ungoliant-controller`'s `NEMOCLAW_TIMEOUT_SECONDS` and its ingress proxy timeouts — don't change this in isolation. | No | `900` | | `dry-run` | Resolve and preview the payload without firing the webhook. | No | `false` | ## Outputs