Overview
When a CnpjGeneratorOptions instance is passed as $options to CnpjGenerator::__construct(), the scalar arguments $format, $prefix, and $type are silently ignored. This is in contrast to the generate() method, which layers scalar args as overrides on top of the instance options.
Design question
Should the constructor apply the same override layering as generate()? Two possible approaches:
- Layer the scalar args as overrides — when
$options is a CnpjGeneratorOptions instance, still apply ['format' => $format, 'prefix' => $prefix, 'type' => $type] on top, making the constructor symmetric with generate().
- Raise an exception when both an options instance and scalar args are provided simultaneously, making the precedence explicit rather than silently favouring the instance.
The current silent-ignore behaviour is documented in the constructor docblock but may surprise consumers who expect symmetry with generate().
References
Raised by @juliolmuller.
Overview
When a
CnpjGeneratorOptionsinstance is passed as$optionstoCnpjGenerator::__construct(), the scalar arguments$format,$prefix, and$typeare silently ignored. This is in contrast to thegenerate()method, which layers scalar args as overrides on top of the instance options.Design question
Should the constructor apply the same override layering as
generate()? Two possible approaches:$optionsis aCnpjGeneratorOptionsinstance, still apply['format' => $format, 'prefix' => $prefix, 'type' => $type]on top, making the constructor symmetric withgenerate().The current silent-ignore behaviour is documented in the constructor docblock but may surprise consumers who expect symmetry with
generate().References
v2][cnpj-gen] Upgrade to latest API and add support to alphanumeric CNPJ format #39v2][cnpj-gen] Upgrade to latest API and add support to alphanumeric CNPJ format #39 (comment)Raised by @juliolmuller.