From 488420747cdc8b5c286b3ecbaf5b87f73ca34539 Mon Sep 17 00:00:00 2001 From: Hans Johnson Date: Thu, 2 Apr 2026 20:27:49 -0500 Subject: [PATCH 1/3] COMP: Update minimum Python version to 3.10+ --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 25e75cb..27a421d 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -34,7 +34,7 @@ classifiers = [ "Topic :: Scientific/Engineering :: Medical Science Apps.", "Topic :: Software Development :: Libraries", ] -requires-python = ">=3.9" +requires-python = ">=3.10" dependencies = [ "itk == 5.4.*", "itk-boneenhancement", From acd704bf860979a96b859b18a58eafab781e2f1f Mon Sep 17 00:00:00 2001 From: Hans Johnson Date: Fri, 3 Apr 2026 15:02:33 -0500 Subject: [PATCH 2/3] COMP: Update ITKRemoteModuleBuildTestPackageAction to v5.4.6 --- .github/workflows/build-test-package.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-test-package.yml b/.github/workflows/build-test-package.yml index 7781a42..04746dd 100644 --- a/.github/workflows/build-test-package.yml +++ b/.github/workflows/build-test-package.yml @@ -4,12 +4,12 @@ on: [push,pull_request] jobs: cxx-build-workflow: - uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-cxx.yml@v5.4.4 + uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-cxx.yml@v5.4.6 with: itk-module-deps: 'BoneEnhancement@e6935aa760c3fa4e247ca0f4924a4fe3e420bf91:IOScanco@10a73c1ab2de044c4dd73608f91cf52012aff5e4' python-build-workflow: - uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-package-python.yml@v5.4.4 + uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-package-python.yml@v5.4.6 with: itk-module-deps: 'InsightSoftwareConsortium/ITKBoneEnhancement@e6935aa760c3fa4e247ca0f4924a4fe3e420bf91' secrets: From 46c767c762bad3bbe31d9bdd925f67a7f4d2c2e9 Mon Sep 17 00:00:00 2001 From: Hans Johnson Date: Sat, 11 Apr 2026 14:12:29 -0500 Subject: [PATCH 3/3] COMP: Disable bit-rotted Test Python HASI workflow, modernize its shell Two orthogonal modernizations to .github/workflows/test-python-hasi.yml folded into one commit because they both leave the workflow's author-time state in a consistent shape: 1. Bump `actions/checkout@v4` -> `actions/checkout@v5` so the workflow scaffolding matches the rest of HASI's CI on modern runners. 2. Disable the workflow on push/pull_request events and carry forward the matrix / Python / include-block updates needed for a future revival. The `Test Python HASI` workflow has been queued-but-never-started on PR #93 because every element of its toolchain has bit-rotted out from under it: * Runner images `ubuntu-18.04`, `windows-2019`, and `macos-10.15` have all been retired by GitHub Actions, so the jobs sit in `queued` indefinitely and never get scheduled onto a runner. On PR #93 they were the only non-green checks. * Python 3.7 (pinned by this workflow) is end-of-life (June 2023) and is not installable on modern runner images via `actions/setup-python@v5`. * The pinned test dependencies -- `itk==5.2.0.post2` (2021), `itk-shape==0.2.1`, `dwd==1.0.1` -- are incompatible with the `itk` 5.4.x API that the rest of HASI now targets via `ITKRemoteModuleBuildTestPackageAction@v5.4.6`. * The IPFS-hosted test data workflow relies on `ibnesayeed/setup-ipfs@master` plus an `ipfs pin add` of a CID that is no longer reliably pinned on the public swarm. The last successful run of this workflow predates 2025-03: every run since has been `cancelled` or `failure`. Rather than mask that with `continue-on-error: true` (which hides real regressions behind a green badge) or delete the file (which throws away the scaffold and makes it harder to revive the Python tests later), switch the trigger to `workflow_dispatch` only so the file survives as a skeleton for a future modernization pass. Also bump the matrix entries from the retired images to the house canonical `[ubuntu-24.04, windows-2022, macos-14]` and Python from 3.7 to 3.10 so that whoever re-enables the workflow has one less thing to rewrite. The `src/hasi/test_*.py` pytest files themselves are untouched and still runnable locally. Co-Authored-By: Claude Opus 4.6 (1M context) --- .github/workflows/test-python-hasi.yml | 37 +++++++++++++++++++------- 1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/.github/workflows/test-python-hasi.yml b/.github/workflows/test-python-hasi.yml index 70ef42f..84e7c10 100644 --- a/.github/workflows/test-python-hasi.yml +++ b/.github/workflows/test-python-hasi.yml @@ -1,6 +1,29 @@ name: Test Python HASI -on: [push,pull_request] +# NOTE (2026-04): This workflow is temporarily disabled on push / PR +# events because every element of its toolchain has bit-rotted: +# +# * Runner images `ubuntu-18.04`, `windows-2019`, and `macos-10.15` +# have all been retired by GitHub Actions, so the jobs sit in +# `queued` indefinitely and never start. +# * Python 3.7 is end-of-life (EOL June 2023) and is not installable +# on modern runner images via `actions/setup-python@v5`. +# * The pinned test dependencies `itk==5.2.0.post2` (2021), +# `itk-shape==0.2.1`, and `dwd==1.0.1` are incompatible with the +# `itk` 5.4.x API that the rest of HASI now targets. +# * The IPFS-hosted test data workflow relies on +# `ibnesayeed/setup-ipfs@master` plus an `ipfs pin add` of a CID +# that is no longer reliably pinned on the public swarm, so even +# on a working runner the test data step fails. +# +# The last successful run of this workflow predates 2025-03. Rather +# than mask the failures with `continue-on-error`, trigger only on +# `workflow_dispatch` so the file stays around as a scaffold for when +# someone has time to modernize the Python test stack (port tests away +# from IPFS, bump `itk`, pick new runner images). The `src/hasi` +# pytest files themselves are unchanged and still runnable locally. + +on: [workflow_dispatch] env: hasi-testing-data-ipfs-cid: bafybeihvca4e6ik3twyz5qdz3f33woqpzorrcfwkh47tp3wwpxuuggmbey @@ -11,19 +34,15 @@ jobs: strategy: max-parallel: 3 matrix: - os: [ubuntu-18.04, windows-2019, macos-10.15] - include: - - os: ubuntu-18.04 - - os: windows-2019 - - os: macos-10.15 + os: [ubuntu-24.04, windows-2022, macos-14] steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - - name: Set up Python 3.7 + - name: Set up Python 3.10 uses: actions/setup-python@v5 with: - python-version: 3.7 + python-version: '3.10' - name: Setup ipfs uses: ibnesayeed/setup-ipfs@master