From dcbc3a8e47a8a06268536f65ffb3a81111db6050 Mon Sep 17 00:00:00 2001 From: William Allen Date: Thu, 14 May 2026 11:45:32 -0400 Subject: [PATCH] Change default builds per build group from 10 to 50 As discussed in https://github.com/Kitware/CDash/issues/3715, a default of 10 builds per build group is insufficient for many projects. This low limit was set in an era when AngularJS rendering for the full page was extremely slow. This is no longer an issue, and it now makes sense to increase the default number of builds per build group. I have somewhat arbitrarily chosen 50 as the new default for all types of pagination across the site. I plan to make further improvements to this in the next ~6-12 months as part of the transition to Vue. --- resources/js/angular/controllers/index.js | 2 +- resources/js/angular/controllers/queryTests.js | 2 +- resources/js/angular/controllers/testOverview.js | 2 +- tests/cypress/e2e/query-tests.cy.js | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/resources/js/angular/controllers/index.js b/resources/js/angular/controllers/index.js index 62283e05e5..5f94a7e759 100644 --- a/resources/js/angular/controllers/index.js +++ b/resources/js/angular/controllers/index.js @@ -128,7 +128,7 @@ export function IndexController($scope, $rootScope, $location, $http, $filter, $ if(num_per_page_cookie) { $scope.cdash.buildgroups[i].pagination.numPerPage = parseInt(num_per_page_cookie); } else { - $scope.cdash.buildgroups[i].pagination.numPerPage = 10; + $scope.cdash.buildgroups[i].pagination.numPerPage = 50; } // Setup sorting. diff --git a/resources/js/angular/controllers/queryTests.js b/resources/js/angular/controllers/queryTests.js index cefa0ad219..673929c6cb 100644 --- a/resources/js/angular/controllers/queryTests.js +++ b/resources/js/angular/controllers/queryTests.js @@ -12,7 +12,7 @@ export function QueryTestsController($scope, $rootScope, $filter, apiLoader, fil if(num_per_page_cookie) { $scope.pagination.numPerPage = parseInt(num_per_page_cookie); } else { - $scope.pagination.numPerPage = 25; + $scope.pagination.numPerPage = 50; } // Hide filters by default. diff --git a/resources/js/angular/controllers/testOverview.js b/resources/js/angular/controllers/testOverview.js index 500edcb878..2af10179ef 100644 --- a/resources/js/angular/controllers/testOverview.js +++ b/resources/js/angular/controllers/testOverview.js @@ -35,7 +35,7 @@ export function TestOverviewController($scope, $rootScope, $filter, apiLoader, f if(num_per_page_cookie) { $scope.pagination.numPerPage = parseInt(num_per_page_cookie); } else { - $scope.pagination.numPerPage = 10; + $scope.pagination.numPerPage = 50; } apiLoader.loadPageData($scope, 'api/v1/testOverview.php'); diff --git a/tests/cypress/e2e/query-tests.cy.js b/tests/cypress/e2e/query-tests.cy.js index 374b196ec0..8d1a86797d 100644 --- a/tests/cypress/e2e/query-tests.cy.js +++ b/tests/cypress/e2e/query-tests.cy.js @@ -49,6 +49,6 @@ describe('query tests', () => { // load the page and verify the expected number of tests. cy.visit(expected_url); cy.get('#numtests').should('contain', 'Query Tests: 126 matches'); - cy.get('#queryTestsTable').find('tbody').find('tr').should('have.length', 25); + cy.get('#queryTestsTable').find('tbody').find('tr').should('have.length', 50); }); });