[MISC] Reproducible Build fails for v1.5.3

[IzzySoft]

… because your APK contains an additional file:

  -rw-r--r--  0.0 unx    10760 b-    10760 stor 1981-01-01 01:01:02 81bd88ae lib/x86_64/libandroidx.graphics.path.so
- -rw-r--r--  0.0 unx       26 b-       17 defN 1981-01-01 01:01:02 c28a5186 assets/adi-registration.properties
  -rw-r--r--  0.0 unx     1000 b-      579 defN 1981-01-01 01:01:02 c82563e1 assets/shaders/fragment_shader_alpha_scale_es2.glsl

Not sure how that got in there, or what it is meant for – but when we build, it's simply not there.

[JoshAtticus]

Apologies! That's the Google Play Developer Verification registration file. Without it, Compressor would be blocked from all certified Android devices later this year (that is, unless enough people fight back against it, I've already filed a complaint with the ACCC here in Australia). I was under the assumption that this file was meant to be kept secret, however turns out it's useless without my private signing key anyways, so I've removed it from my .gitignore, committed it and updated the latest release to use the new commit hash! Hopefully that fixes the issue.

[IzzySoft]

Thanks! One problem you've introduced there:

and updated the latest release

Never replace what was already distributed – that APK was already pulled to our repo, so we have to mark it "RB failed" now (we cannot match it anymore, as it's a different APK now). Next release will be RB then again, hopefully 🤞

[JoshAtticus]

Thanks! One problem you've introduced there:

and updated the latest release

Never replace what was already distributed – that APK was already pulled to our repo, so we have to mark it "RB failed" now (we cannot match it anymore, as it's a different APK now). Next release will be RB then again, hopefully 🤞

I didn't change the APK uploaded, I only changed the commit on the release to match the APK!

[IzzySoft]

that might be – but that release was already processed, so it won't be processed again 🤷‍♂️ Also, this is what your APK says about the commit to build it from:

repositories {
  system: GIT
  local_root_path: "$PROJECT_DIR"
  revision: "aa452b420f3a033509a5a5dd5d702515b15e64ff"
}

And this is what the tag points to: 506518b

Which means trying it now, would result in a different META-INF/version-control-info.textproto in the APK built from the tagged commit. It would be technically possible now to make RB succeed (git checkout 506518bb4 && git reset --soft aa452b4) – but results of the RB check have already been committed (we usually do not hold them back for more than 24h)…

[IzzySoft]

PS: but thanks a lot for the details, Josh! I made myself some notes (probably to be transferred to our documentation later) for similar cases in the future. Now that I know the background (which should not even be there – thanks for also filing a complaint on that!), this gives us options to "adjust" whenever it happens again (we clearly know what to tell the devs in such cases, which makes a fix within the 24h time frame possible – for a one-time "local fix" we could even include something like echo "<registrationKey>" > app/src/main/assets/adi-registration.properties with our build recipe, to be removed once the dev has "un-ignored" it).