fix: preserve PostgreSQL quoted names, numeric scales and comment literals (#2638)

* fix: preserve PostgreSQL quoted names, numeric scales and comment literals

* refactor: clarify table identifier copying responsibilities

Author: minleejae

src/main/java/net/sf/jsqlparser/schema/Table.java

@@ -521,15 +521,16 @@ public Table getResolvedTable() {
     }
 
     /**
-     * Sets resolved table.
+     * Stores a detached copy of the resolved table's identifier. Reference-specific flags and
+     * clauses are not copied.
      *
      * @param resolvedTable the resolved table
      * @return this table
      */
     public Table setResolvedTable(Table resolvedTable) {
-        // clone, not reference
         if (resolvedTable != null) {
-            this.resolvedTable = new Table(resolvedTable.getFullyQualifiedName());
+            this.resolvedTable = new Table();
+            resolvedTable.copyIdentifierPartsTo(this.resolvedTable);
         }
         return this;
     }
@@ -577,11 +578,19 @@ public static Table[] setUnsetCatalogAndSchema(String currentCatalogName,
         return tables;
     }
 
+    /** Copies the table identifier, table-variable flag and resolved table identifier. */
     @Override
     public Table clone() {
-        Table clone = new Table(this.getFullyQualifiedName());
+        Table clone = new Table();
+        copyIdentifierPartsTo(clone);
         clone.setTableVariable(tableVariable);
         clone.setResolvedTable(this.resolvedTable != null ? this.resolvedTable.clone() : null);
         return clone;
     }
+
+    /** Copies identifier components and separators, leaving the target's other state unchanged. */
+    private void copyIdentifierPartsTo(Table target) {
+        target.partItems = new ArrayList<>(partItems);
+        target.partDelimiters = new ArrayList<>(partDelimiters);
+    }
 }

src/main/java/net/sf/jsqlparser/statement/create/table/ColDataType.java

@@ -54,12 +54,27 @@ public ColDataType() {
     }
 
     public ColDataType(String dataType, int precision, int scale) {
-        this.dataType = dataType;
+        this(dataType);
+        setNumericParameters(precision < 0 ? null : Integer.valueOf(precision),
+                scale < 0 ? null : Integer.valueOf(scale));
+    }
+
+    /**
+     * Creates a parameterized type, using {@code null} for an omitted parameter. Unlike the legacy
+     * primitive constructor, this accepts negative scales, including {@code -1}.
+     */
+    public static ColDataType fromNumericParameters(String dataType, Integer precision,
+            Integer scale) {
+        ColDataType type = new ColDataType(dataType);
+        type.setNumericParameters(precision, scale);
+        return type;
+    }
 
-        if (precision >= 0) {
+    private void setNumericParameters(Integer precision, Integer scale) {
+        if (precision != null) {
             this.precision = precision;
             this.dataType += " (" + (precision == Integer.MAX_VALUE ? "MAX" : precision);
-            if (scale >= 0) {
+            if (scale != null) {
                 this.scale = scale;
                 this.dataType += ", " + scale;
             }
@@ -211,8 +226,8 @@ public void setPrecision(Integer precision) {
     }
 
     /**
-     * The second numeric type parameter, e.g. {@code 2} for {@code DECIMAL(10, 2)}. Returns
-     * {@code null} when absent.
+     * The second numeric type parameter, e.g. {@code 2} for {@code DECIMAL(10, 2)} or {@code -3}
+     * for PostgreSQL {@code NUMERIC(2, -3)}. Returns {@code null} when absent.
      */
     public Integer getScale() {
         return scale;