Fix ALTER deparser dispatch for inactive column metadata (#2770)

* Fix ALTER deparser dispatch for inactive column metadata

Signed-off-by: minleejae <mmj9808@gmail.com>

* test: isolate table traversal benchmark from parser timeout

Signed-off-by: minleejae <mmj9808@gmail.com>

---------

Signed-off-by: minleejae <mmj9808@gmail.com>

Author: minleejae

src/main/java/net/sf/jsqlparser/statement/alter/AlterConstraintAttributes.java

@@ -38,6 +38,16 @@ public List<ColumnIdentityAction> getColumnIdentityActions() {
         return Collections.emptyList();
     }
 
+    @Override
+    protected boolean usesColumnActionBody() {
+        return false;
+    }
+
+    @Override
+    public boolean hasActiveColumnDefinitions() {
+        return false;
+    }
+
     @Override
     public boolean hasActiveTableDefinition() {
         return false;

src/main/java/net/sf/jsqlparser/statement/alter/AlterExpression.java

@@ -482,8 +482,7 @@ public List<ColumnSetDefault> getColumnSetDefaultList() {
      * existing action-specific API to add or remove entries.
      */
     public List<ColumnDefaultAction> getColumnDefaults() {
-        if (operation != AlterOperation.ALTER || columnSetDefaultList == null
-                || constraintType != null && constraintSymbol != null
+        if (!usesColumnActionBody() || columnSetDefaultList == null
                 || columnDropDefaultList != null && !columnDropDefaultList.isEmpty()) {
             return Collections.emptyList();
         }
@@ -1077,7 +1076,7 @@ protected void appendBody(StringBuilder b) {
             b.append(optionalSpecifier);
         } else if (hasExplicitConstraintHeader()) {
             toStringConstraintAlter(b);
-        } else if (hasAlterColumnValueActions()) {
+        } else if (usesColumnActionBody()) {
             toStringAlterColumn(b);
         } else if (isSimpleKeywordOperation()) {
             toStringSimpleKeyword(b);
@@ -1101,6 +1100,32 @@ private boolean hasAlterColumnValueActions() {
                         || columnSetVisibilityList != null && !columnSetVisibilityList.isEmpty());
     }
 
+    /**
+     * Whether the selected body renders ALTER COLUMN default or visibility actions. Subclasses
+     * overriding {@link #appendBody(StringBuilder)} must reflect their dispatch here as well.
+     */
+    protected boolean usesColumnActionBody() {
+        return hasAlterColumnValueActions() && !hasExplicitConstraintHeader();
+    }
+
+    /**
+     * Whether this action currently renders its column definitions through the general body.
+     * Inactive column metadata is retained in the AST but must not select a different body when
+     * deparsing. Subclasses with their own body dispatch override this method accordingly.
+     */
+    public boolean hasActiveColumnDefinitions() {
+        return hasColumnDefinitionPayload() && operation != AlterOperation.UNSPECIFIC
+                && !hasExplicitConstraintHeader() && !usesColumnActionBody()
+                && !isSimpleKeywordOperation() && !isRenameOperation() && !isDropSpecialOperation()
+                && operation != AlterOperation.CONVERT && operation != AlterOperation.COLLATE
+                && !isPartitionOperation();
+    }
+
+    /** Whether column definitions take precedence within the general body. */
+    protected boolean hasColumnDefinitionPayload() {
+        return commentText == null && columnName == null && colDataTypeList != null;
+    }
+
     /**
      * Appends the common tail (parameters, index comment) shared by all ALTER expressions.
      */

src/main/java/net/sf/jsqlparser/statement/alter/AlterExpressionCharset.java

@@ -25,6 +25,16 @@ public List<ColumnIdentityAction> getColumnIdentityActions() {
         return Collections.emptyList();
     }
 
+    @Override
+    protected boolean usesColumnActionBody() {
+        return false;
+    }
+
+    @Override
+    public boolean hasActiveColumnDefinitions() {
+        return false;
+    }
+
     @Override
     public boolean hasActiveTableDefinition() {
         return false;

src/main/java/net/sf/jsqlparser/statement/alter/AlterExpressionDrop.java

@@ -24,6 +24,17 @@ public List<ColumnIdentityAction> getColumnIdentityActions() {
         return getColumnIdentityActionsFromDefinitions();
     }
 
+    @Override
+    protected boolean usesColumnActionBody() {
+        return false;
+    }
+
+    @Override
+    public boolean hasActiveColumnDefinitions() {
+        return hasColumnDefinitionPayload() && !isDropSpecialOperation()
+                && getOperation() != AlterOperation.DROP_PARTITION;
+    }
+
     @Override
     public boolean hasActiveTableDefinition() {
         return false;

src/main/java/net/sf/jsqlparser/statement/alter/AlterExpressionOrderBy.java

@@ -35,6 +35,16 @@ public List<ColumnIdentityAction> getColumnIdentityActions() {
         return Collections.emptyList();
     }
 
+    @Override
+    protected boolean usesColumnActionBody() {
+        return false;
+    }
+
+    @Override
+    public boolean hasActiveColumnDefinitions() {
+        return false;
+    }
+
     @Override
     public boolean hasActiveTableDefinition() {
         return false;

src/main/java/net/sf/jsqlparser/statement/alter/AlterExpressionPartition.java

@@ -270,6 +270,16 @@ public List<ColumnIdentityAction> getColumnIdentityActions() {
         return Collections.emptyList();
     }
 
+    @Override
+    protected boolean usesColumnActionBody() {
+        return false;
+    }
+
+    @Override
+    public boolean hasActiveColumnDefinitions() {
+        return false;
+    }
+
     @Override
     public boolean hasActiveTableDefinition() {
         return false;

src/main/java/net/sf/jsqlparser/statement/alter/AlterExpressionPrimaryKey.java

@@ -39,6 +39,16 @@ public List<ColumnIdentityAction> getColumnIdentityActions() {
         return Collections.emptyList();
     }
 
+    @Override
+    protected boolean usesColumnActionBody() {
+        return false;
+    }
+
+    @Override
+    public boolean hasActiveColumnDefinitions() {
+        return false;
+    }
+
     @Override
     public boolean hasActiveTableDefinition() {
         return false;

src/main/java/net/sf/jsqlparser/statement/alter/AlterExpressionRename.java

@@ -50,6 +50,16 @@ public List<ColumnIdentityAction> getColumnIdentityActions() {
         return Collections.emptyList();
     }
 
+    @Override
+    protected boolean usesColumnActionBody() {
+        return false;
+    }
+
+    @Override
+    public boolean hasActiveColumnDefinitions() {
+        return getOperation() == AlterOperation.RENAME && hasColumnDefinitionPayload();
+    }
+
     @Override
     public boolean hasActiveTableDefinition() {
         return false;

src/main/java/net/sf/jsqlparser/statement/alter/AlterExpressionTableOption.java

@@ -41,6 +41,16 @@ public List<ColumnIdentityAction> getColumnIdentityActions() {
         return Collections.emptyList();
     }
 
+    @Override
+    protected boolean usesColumnActionBody() {
+        return false;
+    }
+
+    @Override
+    public boolean hasActiveColumnDefinitions() {
+        return false;
+    }
+
     @Override
     public boolean hasActiveTableDefinition() {
         return false;

src/main/java/net/sf/jsqlparser/statement/alter/AlterForeignDataOptions.java

@@ -47,6 +47,16 @@ public List<ColumnIdentityAction> getColumnIdentityActions() {
         return Collections.emptyList();
     }
 
+    @Override
+    protected boolean usesColumnActionBody() {
+        return false;
+    }
+
+    @Override
+    public boolean hasActiveColumnDefinitions() {
+        return false;
+    }
+
     @Override
     public boolean hasActiveTableDefinition() {
         return false;