From b091cada06c92f9d0f60578bd2c6785b6bc08a35 Mon Sep 17 00:00:00 2001 From: Angel Caamal Date: Thu, 27 Aug 2026 18:42:33 +0000 Subject: [PATCH 1/4] chore(ci): upgrade Node.js version from 16 to 20 in workflows --- .github/workflows/test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 7dfe3ea5642..7daa087172e 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -42,7 +42,7 @@ jobs: access_token_lifetime: 600s - uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0 with: - node-version: 16 + node-version: 20 - name: Get npm cache directory id: npm-cache-dir shell: bash From 972418e25573cb078d9a6b830b8ffbcf59786e10 Mon Sep 17 00:00:00 2001 From: Angel Caamal Date: Thu, 27 Aug 2026 20:33:09 +0000 Subject: [PATCH 2/4] ci: upgrade Node.js to 20 and prevent template injection in test workflow --- .github/workflows/test.yaml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 7daa087172e..ecf3c829926 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -40,7 +40,7 @@ jobs: service_account: 'kokoro-system-test@long-door-651.iam.gserviceaccount.com' create_credentials_file: 'true' access_token_lifetime: 600s - - uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0 + - uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.2.4 with: node-version: 20 - name: Get npm cache directory @@ -58,10 +58,14 @@ jobs: run: echo "MOCHA_REPORTER_OUTPUT=${{github.run_id}}_sponge_log.xml" >> $GITHUB_ENV - name: set testing env vars for scheduled run if: github.event.action == 'schedule' + env: + SUITE_NAME: ${{ inputs.name }} run: | - echo "MOCHA_REPORTER_SUITENAME=${{ inputs.name }}" >> $GITHUB_ENV + echo "MOCHA_REPORTER_SUITENAME=${{SUITE_NAME}}" >> $GITHUB_ENV echo "MOCHA_REPORTER=xunit" >> $GITHUB_ENV - name: Run Tests - run: make test dir=${{ inputs.path }} env: GOOGLE_SAMPLES_PROJECT: "long-door-651" + SAMPLE_PATH: ${{ inputs.path }} + run: make test dir=${{SAMPLE_PATH}} + From 8eb17de7dd4a28146bf709faae72b468885b9966 Mon Sep 17 00:00:00 2001 From: Angel Caamal Date: Thu, 27 Aug 2026 21:21:47 +0000 Subject: [PATCH 3/4] fix(ci): correct bash variable syntax and add quotes to workflow steps --- .github/workflows/test.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index ecf3c829926..3a97a21647a 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -47,7 +47,7 @@ jobs: id: npm-cache-dir shell: bash run: echo "dir=$(npm config get cache)" >> ${GITHUB_OUTPUT} - - uses: actions/cache@0400d5f644dc74513175e3cd8d07132dd4860809 # v4 + - uses: actions/cache@0400d5f644dc74513175e3cd8d07132dd4860809 # v4.2.4 id: npm-cache with: path: ${{ steps.npm-cache-dir.outputs.dir }} @@ -61,11 +61,11 @@ jobs: env: SUITE_NAME: ${{ inputs.name }} run: | - echo "MOCHA_REPORTER_SUITENAME=${{SUITE_NAME}}" >> $GITHUB_ENV + echo "MOCHA_REPORTER_SUITENAME=${SUITE_NAME}" >> $GITHUB_ENV echo "MOCHA_REPORTER=xunit" >> $GITHUB_ENV - name: Run Tests env: GOOGLE_SAMPLES_PROJECT: "long-door-651" SAMPLE_PATH: ${{ inputs.path }} - run: make test dir=${{SAMPLE_PATH}} + run: make test dir="${SAMPLE_PATH}" From bdbce57dd41910c0bbece0851a11e93241f27850 Mon Sep 17 00:00:00 2001 From: Angel Caamal Date: Thu, 27 Aug 2026 21:47:17 +0000 Subject: [PATCH 4/4] chore(ci): upgrade Node.js version from 16 to 20 in workflows --- .github/workflows/test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 3a97a21647a..3c4de62425c 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -40,7 +40,7 @@ jobs: service_account: 'kokoro-system-test@long-door-651.iam.gserviceaccount.com' create_credentials_file: 'true' access_token_lifetime: 600s - - uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.2.4 + - uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0 with: node-version: 20 - name: Get npm cache directory