From d573839590cd50511001b3adc5df7a08f88a7064 Mon Sep 17 00:00:00 2001 From: Aarnav Koushik Date: Sat, 29 Aug 2026 10:16:13 -0700 Subject: [PATCH] Remove Thousands Separators From CANdo Numeric Values --- Autogen/CAN/Doc/GRCAN.CANdo | 2 +- Autogen/CAN/Src/DBCparser.pl | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Autogen/CAN/Doc/GRCAN.CANdo b/Autogen/CAN/Doc/GRCAN.CANdo index 80cc18dc1..ca330e0df 100644 --- a/Autogen/CAN/Doc/GRCAN.CANdo +++ b/Autogen/CAN/Doc/GRCAN.CANdo @@ -536,7 +536,7 @@ Message ID: data type: u32 units: ms scaled min: 0 - scaled max: 4,294,967,296 + scaled max: 4294967296 map equation: "1x" ECU Status 1: MSG ID: 0x003 diff --git a/Autogen/CAN/Src/DBCparser.pl b/Autogen/CAN/Src/DBCparser.pl index b266ce87c..534e1baaf 100644 --- a/Autogen/CAN/Src/DBCparser.pl +++ b/Autogen/CAN/Src/DBCparser.pl @@ -9,7 +9,7 @@ # (which equals the corresponding "Bus ID:" name). # # Per-file DBC validity is enforced by: -# - numeric ranges stripped of thousands separators (no commas in numbers) +# - numeric ranges use plain integers (no thousands separators) # - identifiers normalized to [A-Za-z_][A-Za-z0-9_]* (leading digits prefixed) # - identifier length capped at 32 chars; long message names dedup leading # tokens that already appear in the sender, and any composed name still @@ -572,7 +572,6 @@ sub _to_number { my ($v) = @_; if ( !defined $v ) { return 0; } $v =~ s/["'\s]//gsmx; - $v =~ s/,//gsmx; if ( $v !~ /^-?\d/smx ) { return 0; } return ( $v + 0 ); }