Images are silently resampled to bigger Size

[realulim]

Describe the bug

This problem is reproducible with the Online Demo at https://addonsv24.flowingcode.com/image-crop/upload

Upload an image of, say, 900x640 pixels. Once the crop dialog is opened, this image has been resampled to a bigger size. With my main test image this resulted in 1152x768 pixels, but I cannot share that image. I've created a test image, which I am going to attach here, and that is upsampled to 1080x768.

Either way, I don't know where this happens, but the end result is that a cropped image could actually have more pixels than the original - although it is of course unsharper due to resampling.

Expected behavior

That the original image is used verbatim.

Minimal reproducible example

https://addonsv24.flowingcode.com/image-crop/upload

The problem is also easily reproducible with the "Basic Image Crop" in the Online Demo. Just select the entire image with the crop tool and compare original image and cropped image. I attach a screenshot showing that the cropped image is actually larger than the original.

Add-on Version

1.1.2

Vaadin Version

24.6.5

Additional information

[realulim]

Further testing with my application revealed that the problem does not occur with a circular crop, only with the rectangular crop. Aspect ratio has no influence.

[realulim]

Further testing revealed that the scaling occurs in image-crop.tsx, where width and height are multiplied by a pixelRatio constant, which is derived from window.devicePixelRatio and in my case this comes out as 1.2.

Now, I am not sure what the purpose of this scaling is. To me the plugin works as expected, if I set the pixelRatio to 1.0.

[javier-godoy]

Hello. Thanks for pointing this out. We're taking a look at how pixelRatio is initialized and will re-evaluate the logic

ImageCrop/src/main/resources/META-INF/resources/frontend/src/image-crop.tsx

Line 178 in 8fcf058

const pixelRatio = window.devicePixelRatio;