Skip to content

Commit da64cbf

Browse files
committed
Fix require() of the CommonJS build
The package is "type": "module", so Node treated dist/feascript.cjs.js as an ES module and require("feascript") failed with ERR_REQUIRE_ESM. Build the CommonJS bundle as dist/feascript.cjs and point "main" and "exports.require" at it. import is unchanged.
1 parent e727295 commit da64cbf

5 files changed

Lines changed: 7 additions & 7 deletions

File tree

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

‎dist/feascript.cjs.js.map‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎dist/feascript.cjs.map‎

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22
"name": "feascript",
33
"version": "0.3.0",
44
"description": "Finite element simulation library built in JavaScript",
5-
"main": "dist/feascript.cjs.js",
5+
"main": "dist/feascript.cjs",
66
"module": "dist/feascript.esm.js",
77
"browser": "dist/feascript.umd.js",
88
"exports": {
99
"import": "./dist/feascript.esm.js",
10-
"require": "./dist/feascript.cjs.js"
10+
"require": "./dist/feascript.cjs"
1111
},
1212
"files": [
1313
"dist",

‎rollup.config.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const rewriteWorkerUrl = {
1313
renderChunk(code, chunk) {
1414
// Replace the source-relative wrapper.js path with the dist-sibling path so the
1515
// bundle resolves feascript-worker.esm.js correctly from any host path.
16-
if (/feascript\.(esm|cjs|umd)\.js$/.test(chunk.fileName)) {
16+
if (/feascript\.(esm\.js|cjs|umd\.js)$/.test(chunk.fileName)) {
1717
return {
1818
code: code.replace('"./wrapper.js"', '"./feascript-worker.esm.js"'),
1919
map: null,
@@ -46,7 +46,7 @@ export default [
4646
input: "src/index.js",
4747
output: [
4848
{
49-
file: "dist/feascript.cjs.js",
49+
file: "dist/feascript.cjs", // .cjs, since the package is "type": "module"
5050
format: "cjs",
5151
sourcemap: true,
5252
},

0 commit comments

Comments
 (0)