Repository navigation
Commit b29edd8
committed
Fix 1D convection and nonzero front values; check boundary conditions
- Fix the sign of the 1D convection (Robin) condition: the wall surface
temperature now matches the analytical solution (7.6087 °C instead of
10.294 °C in the 1D wall example). Update the regression test values.
- Impose front propagation Dirichlet values as Newton-Raphson increments,
for both the matrix and frontal solvers, so nonzero constantValue
boundaries converge. Add the u(0) = 1 case to the planar front test.
- Reuse the compute engine passed to solveAsync instead of ignoring it;
without one, a temporary engine is created as before.
- Report unknown boundary condition types when solving, wrap plain-string
conditions in an array with a warning, and report beam conditions that
are not an array of conditions. Add boundaryConditions unit test.
- Use ["zeroGradient"] in the general form examples and tests.
- Replace the deprecated "constantTemp" in the README and examples, and
link the documentation from the README.1 parent 1af81fa commit b29edd8
33 files changed
Lines changed: 322 additions & 81 deletions
File tree
- dist
- examples
- generalFormPDEScript
- advectionDiffusion1D
- nonlinearReactionDiffusion1D
- heatConductionScript
- heatConduction1DWall
- heatConduction2DFin
- src
- physics
- solvers
- tests
- regression
- AdvectionDiffusion1D
- HeatConduction1DWall
- NonlinearReactionDiffusion1D
- unit
- verification/analytical/frontPropagation1DPlanarFront
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| 48 | + | |
| 49 | + | |
48 | 50 | | |
49 | 51 | | |
50 | 52 | | |
| |||
153 | 155 | | |
154 | 156 | | |
155 | 157 | | |
156 | | - | |
| 158 | + | |
157 | 159 | | |
158 | 160 | | |
159 | 161 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| |||
0 commit comments