Workspace - Vendor row does not follow the correct order in LHN

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.4.74-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://github.com/Expensify/Expensify/issues/416301
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Enable all features in workspace settings > More features.
• Connect workspace to Sage Intacct.

1. Go to staging.new.expensify.com
2. Go to workspace settings > More features.

Expected Result:

The order of features in LHN will match the features in More features.

Actual Result:

The order of features in LHN does not match the features in More features.

The order of "Organize" feature is Categories > Vendors > Tags > Taxes instead of Categories > Tags > Taxes > Vendors.

Workaround:

N/A

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7237435_1787157754172.2.mp4

Issue Owner

Current Issue Owner: @eh2077

[MelvinBot]

Proposal

What is the root cause of that problem?

The LHN menu is built by pushing items into an array in source order, and the Vendors push sits between Categories and Tags instead of after Taxes.

In src/pages/workspace/getWorkspaceMenuItems.ts:267-275 the Vendors block is placed directly after the Categories block (255-265) and before Tags (277-286) and Taxes (288-298).

The More features page renders the Organize section in the correct order — Categories, Tags, Taxes, then Vendors last — at WorkspaceMoreFeaturesPage/index.tsx:422-508.

Nothing re-sorts the LHN array downstream, so push order is exactly what the user sees. That produces Categories > Vendors > Tags > Taxes, matching the report.

What changes do you think we should make in order to solve the problem?

1. In getWorkspaceMenuItems.ts, move the Vendors items.push block so it runs after the Taxes block instead of after the Categories block. No logic or conditions change — only position.
2. Update the three ordered assertion arrays in tests/unit/getWorkspaceMenuItemsTest.ts:393-461, which currently pin Vendors at index 8. The translationKey, getRoute, and screenName entries each need to move to index 10.

What alternative solutions did you explore? (Optional)

Sort the LHN from a shared order constant. A single source of truth shared by both surfaces would prevent this class of drift permanently, but it is a much larger refactor than this bug warrants. Worth a separate issue if feature-row drift keeps recurring.

Reorder the More features page instead. Rejected — the Organize section there already matches the expected result described in this issue, so the LHN is the side that is wrong.

Investigation details

Verified: getWorkspaceMenuItems returns its array unmodified, and WorkspaceInitialPage.tsx:175-190 only .map()s over it to attach an action before rendering. No sort, reverse, or orderBy touches it.

Other consumer is unaffected: the Search router also calls getWorkspaceMenuItems, but SearchRouterHelpers.ts:54-69 re-sorts alphabetically, so it discards push order entirely. Moving the block has no effect there.

Why this needs Sage Intacct to reproduce: the LHN Vendors row requires hasVendorFeature (PolicyUtils.ts:2534-2543) plus a hydrated vendor list. For Sage Intacct that means the connection must be in Credit Card Charge non-reimbursable mode and the vendor-matching beta must be on. QBO in card mode qualifies without the beta.

Browser check: I drove a fresh Collect workspace on web with all available features enabled. The Organize section and the LHN both showed Categories > Tags > Taxes, matching each other. No Vendors row appeared in either place, since the test workspace has no accounting connection — so this run confirms the non-Vendors baseline is correct but does not itself reproduce the reported mismatch. The code path above accounts for it.

Unrelated observation: the Vendors item is the only Organize row with no highlighted field, so a freshly-enabled Vendors feature will not get the highlight animation. Out of scope here.

Related issues: a scan of open Expensify/App issues found no duplicate or closely related report.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/100712) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

---

view run · no recording available

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.