From 287c0a7f9dac1df4d43b52a1e20e8aa934ddd50b Mon Sep 17 00:00:00 2001 From: Attila Gombos Date: Mon, 2 Feb 2026 17:03:23 +0100 Subject: [PATCH] Fix flaky tests --- tests/advertizerIntegrationTest.py | 12 ++++++------ tests/apiIntegrationTest.py | 16 ++++++++-------- tests/discovererIntegrationTest.py | 12 ++++++------ tests/dishReceiverTest.py | 4 ++-- tests/receiverIntegrationTest.py | 2 +- tests/senderIntegrationTest.py | 2 +- 6 files changed, 24 insertions(+), 24 deletions(-) diff --git a/tests/advertizerIntegrationTest.py b/tests/advertizerIntegrationTest.py index 7023aa7..98ad352 100644 --- a/tests/advertizerIntegrationTest.py +++ b/tests/advertizerIntegrationTest.py @@ -37,7 +37,7 @@ def test_sends_hello_when_advertises_service(self): # When advertizer.advertise(SERVICE_INFO) - wait_for_assertion(0.1, lambda: self.assertEqual(1, len(messages))) + wait_for_assertion(1, lambda: self.assertEqual(1, len(messages))) # Then self.assertEqual([SERVICE_INFO.to_dict()], messages) @@ -61,7 +61,7 @@ def test_sends_hello_when_query_received(self): # When test_sender.send(ServiceQuery('test-service', 'test-role')) - wait_for_assertion(0.1, lambda: self.assertEqual(1, len(messages))) + wait_for_assertion(1, lambda: self.assertEqual(1, len(messages))) # Then self.assertEqual([SERVICE_INFO.to_dict()], messages) @@ -86,7 +86,7 @@ def test_sends_hello_when_info_changed_and_query_received(self): query = ServiceQuery('test-service', 'test-role') test_sender.send(query) - wait_for_assertion(0.1, lambda: self.assertEqual(2, len(messages))) + wait_for_assertion(1, lambda: self.assertEqual(2, len(messages))) new_service_info = ServiceInfo( SERVICE_INFO.uuid, SERVICE_INFO.name, SERVICE_INFO.role, {'test': 'http://localhost:9090'} @@ -96,7 +96,7 @@ def test_sends_hello_when_info_changed_and_query_received(self): # When test_sender.send(query) - wait_for_assertion(0.1, lambda: self.assertEqual(4, len(messages))) + wait_for_assertion(1, lambda: self.assertEqual(4, len(messages))) # Then self.assertEqual([ @@ -119,7 +119,7 @@ def test_sends_hello_when_schedules_advertisement_once(self): # When scheduled_advertizer.schedule(SERVICE_INFO, interval=0.01, one_shot=True) - wait_for_assertion(0.1, lambda: self.assertEqual(1, len(messages))) + wait_for_assertion(1, lambda: self.assertEqual(1, len(messages))) # Then self.assertEqual([SERVICE_INFO.to_dict()], messages) @@ -141,7 +141,7 @@ def test_sends_hello_when_schedules_advertisement_periodically(self): scheduled_advertizer.schedule(SERVICE_INFO, interval=0.01) # Then - wait_for_assertion(0.1, lambda: self.assertEqual(5, len(messages))) + wait_for_assertion(1, lambda: self.assertTrue(len(messages) >= 10)) if __name__ == '__main__': diff --git a/tests/apiIntegrationTest.py b/tests/apiIntegrationTest.py index 8d1f616..633aafa 100644 --- a/tests/apiIntegrationTest.py +++ b/tests/apiIntegrationTest.py @@ -34,7 +34,7 @@ def test_discoverer_caches_advertised_service(self): # When advertizer.advertise() - wait_for_assertion(0.1, lambda: self.assertEqual(1, len(discoverer.get_services()))) + wait_for_assertion(1, lambda: self.assertEqual(1, len(discoverer.get_services()))) # Then self.assertEqual({SERVICE_INFO.uuid: SERVICE_INFO}, discoverer.get_services()) @@ -57,7 +57,7 @@ def test_discoverer_caches_advertised_services(self): Thread(target=advertizer1.advertise).start() Thread(target=advertizer2.advertise).start() - wait_for_assertion(0.2, lambda: self.assertEqual(2, len(discoverer.get_services()))) + wait_for_assertion(1, lambda: self.assertEqual(2, len(discoverer.get_services()))) # Then self.assertEqual({ @@ -77,7 +77,7 @@ def test_discoverer_caches_advertised_service_when_advertisement_scheduled_once( # When advertizer.schedule(interval=0.01, one_shot=True) - wait_for_assertion(0.2, lambda: self.assertEqual(1, len(discoverer.get_services()))) + wait_for_assertion(1, lambda: self.assertEqual(1, len(discoverer.get_services()))) # Then self.assertEqual({SERVICE_INFO.uuid: SERVICE_INFO}, discoverer.get_services()) @@ -94,7 +94,7 @@ def test_discoverer_caches_advertised_service_when_advertisement_scheduled_perio # When advertizer.schedule(interval=0.01) - wait_for_assertion(0.2, lambda: self.assertEqual(1, len(discoverer.get_services()))) + wait_for_assertion(1, lambda: self.assertEqual(1, len(discoverer.get_services()))) # Then self.assertEqual({SERVICE_INFO.uuid: SERVICE_INFO}, discoverer.get_services()) @@ -111,7 +111,7 @@ def test_discoverer_caches_discovery_response_service(self): # When discoverer.discover() - wait_for_assertion(0.2, lambda: self.assertEqual(1, len(discoverer.get_services()))) + wait_for_assertion(1, lambda: self.assertEqual(1, len(discoverer.get_services()))) # Then self.assertEqual({SERVICE_INFO.uuid: SERVICE_INFO}, discoverer.get_services()) @@ -132,7 +132,7 @@ def test_discoverer_caches_discovery_response_services(self): # When discoverer.discover() - wait_for_assertion(0.2, lambda: self.assertEqual(2, len(discoverer.get_services()))) + wait_for_assertion(1, lambda: self.assertEqual(2, len(discoverer.get_services()))) # Then self.assertEqual({ @@ -152,7 +152,7 @@ def test_discoverer_caches_discovery_response_service_when_discovery_scheduled_o # When discoverer.schedule(interval=0.01, one_shot=True) - wait_for_assertion(0.2, lambda: self.assertEqual(1, len(discoverer.get_services()))) + wait_for_assertion(1, lambda: self.assertEqual(1, len(discoverer.get_services()))) # Then self.assertEqual({SERVICE_INFO.uuid: SERVICE_INFO}, discoverer.get_services()) @@ -169,7 +169,7 @@ def test_discoverer_caches_discovery_response_service_when_discovery_scheduled_p # When discoverer.schedule(interval=0.01) - wait_for_assertion(0.2, lambda: self.assertEqual(1, len(discoverer.get_services()))) + wait_for_assertion(1, lambda: self.assertEqual(1, len(discoverer.get_services()))) # Then self.assertEqual({SERVICE_INFO.uuid: SERVICE_INFO}, discoverer.get_services()) diff --git a/tests/discovererIntegrationTest.py b/tests/discovererIntegrationTest.py index f444990..b0ad21f 100644 --- a/tests/discovererIntegrationTest.py +++ b/tests/discovererIntegrationTest.py @@ -36,7 +36,7 @@ def test_discovers_service_when_hello_received(self): # When test_sender.send(SERVICE_INFO) - wait_for_assertion(0.1, lambda: self.assertEqual(1, len(discoverer.get_services()))) + wait_for_assertion(1, lambda: self.assertEqual(1, len(discoverer.get_services()))) # Then self.assertEqual({SERVICE_INFO.uuid: SERVICE_INFO}, discoverer.get_services()) @@ -53,7 +53,7 @@ def test_updates_service_when_info_changed(self): test_sender.send(SERVICE_INFO) - wait_for_assertion(0.1, lambda: self.assertEqual(1, len(discoverer.get_services()))) + wait_for_assertion(1, lambda: self.assertEqual(1, len(discoverer.get_services()))) # When new_service_info = ServiceInfo( @@ -61,7 +61,7 @@ def test_updates_service_when_info_changed(self): ) test_sender.send(new_service_info) - wait_for_assertion(0.1, lambda: self.assertEqual( + wait_for_assertion(1, lambda: self.assertEqual( 'http://localhost:9090', discoverer.get_services()[SERVICE_INFO.uuid].urls['test'] )) @@ -87,7 +87,7 @@ def test_sends_query(self): # When discoverer.discover(SERVICE_QUERY) - wait_for_assertion(0.1, lambda: self.assertEqual(1, len(messages))) + wait_for_assertion(1, lambda: self.assertEqual(1, len(messages))) # Then self.assertEqual([SERVICE_QUERY.__dict__], messages) @@ -109,7 +109,7 @@ def test_sends_query_when_schedules_discovery_once(self): # When scheduled_discoverer.schedule(SERVICE_QUERY, interval=0.01, one_shot=True) - wait_for_assertion(0.1, lambda: self.assertEqual(1, len(messages))) + wait_for_assertion(1, lambda: self.assertEqual(1, len(messages))) # Then self.assertEqual([SERVICE_QUERY.__dict__], messages) @@ -132,7 +132,7 @@ def test_sends_query_when_schedules_discovery_periodically(self): scheduled_discoverer.schedule(SERVICE_QUERY, interval=0.01) # Then - wait_for_assertion(0.1, lambda: self.assertEqual(5, len(messages))) + wait_for_assertion(1, lambda: self.assertTrue(len(messages) >= 10)) if __name__ == '__main__': diff --git a/tests/dishReceiverTest.py b/tests/dishReceiverTest.py index f7ad484..047e665 100644 --- a/tests/dishReceiverTest.py +++ b/tests/dishReceiverTest.py @@ -127,7 +127,7 @@ def test_calls_registered_handler_on_message(self): receiver.start(group) # Then - wait_for_assertion(0.1, lambda: handler.assert_called_once_with(SERVICE_INFO.to_dict())) + wait_for_assertion(1, lambda: handler.assert_called_once_with(SERVICE_INFO.to_dict())) def test_handles_message_receive_error_gracefully(self): # Given @@ -168,7 +168,7 @@ def test_handles_handler_execution_error_gracefully(self): receiver.start(group) # Then - wait_for_assertion(0.1, lambda: handler.assert_called_once_with(SERVICE_INFO.to_dict())) + wait_for_assertion(1, lambda: handler.assert_called_once_with(SERVICE_INFO.to_dict())) if __name__ == '__main__': diff --git a/tests/receiverIntegrationTest.py b/tests/receiverIntegrationTest.py index fd17dba..3d014fc 100644 --- a/tests/receiverIntegrationTest.py +++ b/tests/receiverIntegrationTest.py @@ -35,7 +35,7 @@ def test_receives_message(self): # When radio.send_json(SERVICE_INFO.to_dict(), group=group.name) - wait_for_assertion(0.1, lambda: self.assertEqual(1, len(messages))) + wait_for_assertion(1, lambda: self.assertEqual(1, len(messages))) # Then self.assertEqual([SERVICE_INFO.to_dict()], messages) diff --git a/tests/senderIntegrationTest.py b/tests/senderIntegrationTest.py index 319cb7e..9e473ea 100644 --- a/tests/senderIntegrationTest.py +++ b/tests/senderIntegrationTest.py @@ -38,7 +38,7 @@ def test_sends_message(self): # When sender.send(SERVICE_INFO) - wait_for_assertion(0.1, lambda: self.assertEqual(1, len(messages))) + wait_for_assertion(1, lambda: self.assertEqual(1, len(messages))) # Then self.assertEqual([SERVICE_INFO.to_dict()], messages)