diff --git a/hello/discoverer.py b/hello/discoverer.py index d79561f..f2f0d22 100644 --- a/hello/discoverer.py +++ b/hello/discoverer.py @@ -142,7 +142,7 @@ def _create_event(self, group: Group, matcher: ServiceMatcher, stored: Service | return DiscoveryEvent(group, matcher.query, service, DiscoveryEventType.UPDATED) else: log.debug('Service unchanged', group=group, service=service) - return DiscoveryEvent(group, matcher.query, service, DiscoveryEventType.UPDATED) + return DiscoveryEvent(group, matcher.query, service, DiscoveryEventType.UNCHANGED) else: log.info('Service discovered', group=group, service=service) return DiscoveryEvent(group, matcher.query, service, DiscoveryEventType.DISCOVERED) diff --git a/tests/defaultDiscovererTest.py b/tests/defaultDiscovererTest.py index 34e1a66..7839e90 100644 --- a/tests/defaultDiscovererTest.py +++ b/tests/defaultDiscovererTest.py @@ -9,7 +9,6 @@ from hello import Service, Group, ServiceQuery, DefaultDiscoverer, Sender, Receiver, OnDiscoveryEvent, \ DiscoveryEventType, DiscoveryEvent - GROUP = Group('test-group', 'udp://239.0.0.1:5555') SERVICE_QUERY = ServiceQuery('test-.*', 'test-.*') SERVICE = Service( @@ -185,7 +184,7 @@ def test_does_not_call_handler_when_service_not_changed(self): discoverer = DefaultDiscoverer(sender, receiver) discoverer.start(GROUP, SERVICE_QUERY) handler = MagicMock(spec=OnDiscoveryEvent) - discoverer.register(handler) + discoverer.register(handler, {DiscoveryEventType.DISCOVERED, DiscoveryEventType.UPDATED}) discoverer._handle_message(SERVICE.to_dict()) handler.reset_mock() @@ -193,7 +192,8 @@ def test_does_not_call_handler_when_service_not_changed(self): discoverer._handle_message(SERVICE.to_dict()) # Then - handler.assert_not_called() + with self.assertRaises(AssertionError): + wait_for_assertion(0.1, lambda: handler.assert_called()) def test_handles_handler_error_gracefully(self): # Given