From 6a1d8e3c7df293e691ee3d1cbe6862940df76300 Mon Sep 17 00:00:00 2001 From: Tomer Shlasky Date: Wed, 7 Oct 2026 11:33:01 +0000 Subject: [PATCH] chore: remove internal service names and tracker ids from public source MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This repo is public. Four comments named an internal service by its internal codename, referenced an internal tracker id, or both. None of them are needed to understand the code — each is reworded to "the server" or drops the id while keeping the explanation. - src/realtime/config-realtime.ts: session-limit refusal comment - tests/realtime.unit.test.ts: test name + comment for the same behavior - tests/e2e-realtime.test.ts: image_ref prologue comment - tests/e2e.test.ts: drops two internal ticket ids from the garment-fixture note No behavior change. The renamed test is internal to this file. --- packages/sdk/src/realtime/config-realtime.ts | 2 +- packages/sdk/tests/e2e-realtime.test.ts | 2 +- packages/sdk/tests/e2e.test.ts | 2 +- packages/sdk/tests/realtime.unit.test.ts | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/sdk/src/realtime/config-realtime.ts b/packages/sdk/src/realtime/config-realtime.ts index 4b21780..ac61cbc 100644 --- a/packages/sdk/src/realtime/config-realtime.ts +++ b/packages/sdk/src/realtime/config-realtime.ts @@ -37,7 +37,7 @@ export const REALTIME_CONFIG = { /** Close code for a policy termination. */ terminalCloseCode: 1008, /** - * The bouncer's concurrent-session refusal: an `error` message carrying + * The server's concurrent-session refusal: an `error` message carrying * `errorText`, then close `closeCode` with `closeReason`. Retrying it only * takes a slot from whoever is next in line. 1013 with any other reason * ("Try Again Later": upstream at capacity) is transient and still retries. diff --git a/packages/sdk/tests/e2e-realtime.test.ts b/packages/sdk/tests/e2e-realtime.test.ts index afa7d7e..ae36ecb 100644 --- a/packages/sdk/tests/e2e-realtime.test.ts +++ b/packages/sdk/tests/e2e-realtime.test.ts @@ -120,7 +120,7 @@ describe.concurrent("Realtime E2E Tests", { timeout: TIMEOUT, retry: 2 }, () => } // POST /v1/files + image_ref via realtime. Uses lucy-2.1 to actually exercise - // upstream forwarding through the bouncer's image_ref prologue. + // upstream forwarding through the server's image_ref prologue. describe("Files API + image_ref", () => { async function pngBlob(width: number, height: number, color = "#3070C0"): Promise { const canvas = document.createElement("canvas"); diff --git a/packages/sdk/tests/e2e.test.ts b/packages/sdk/tests/e2e.test.ts index 5c35b2f..6c94411 100644 --- a/packages/sdk/tests/e2e.test.ts +++ b/packages/sdk/tests/e2e.test.ts @@ -11,7 +11,7 @@ const OUTPUT_DIR = join(__dirname, "e2e-output"); const VIDEO_FIXTURE = join(__dirname, "fixtures", "video.mp4"); const IMAGE_FIXTURE = join(__dirname, "fixtures", "image.png"); // Try-on models take the GARMENT as reference_image; a non-garment reference (the dogs above) makes -// the try-on models undress the subject and the output fails moderation (PLA-808, PLA-817). +// the try-on models undress the subject and the output fails moderation. const GARMENT_FIXTURE = join(__dirname, "fixtures", "garment.png"); const TIMEOUT = 5 * 60 * 1000; // 5 minutes diff --git a/packages/sdk/tests/realtime.unit.test.ts b/packages/sdk/tests/realtime.unit.test.ts index aff6c44..7d44ebd 100644 --- a/packages/sdk/tests/realtime.unit.test.ts +++ b/packages/sdk/tests/realtime.unit.test.ts @@ -2027,8 +2027,8 @@ describe("StreamSession startup orchestration", () => { expect(errors).toEqual([]); }); - it("does not retry the bouncer's session-limit refusal during the handshake", async () => { - // The bouncer sends an `error` message, then closes 1013 "Session Limit Reached". Each + it("does not retry the server's session-limit refusal during the handshake", async () => { + // The server sends an `error` message, then closes 1013 "Session Limit Reached". Each // retry would be a fresh dial that takes a freed slot ahead of the app's own queue. const { session, ws, ended, connectPromise } = await openHandshake({ initialImage: "queued-garment" });