Skip to content

Commit 388ebfb

Browse files
committed
Add is_crash tag to crash report
1 parent e13fb4e commit 388ebfb

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

‎dd-java-agent/agent-crashtracking/src/main/java/datadog/crashtracking/CrashUploader.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@ public CrashUploader(@Nonnull final ConfigManager.StoredConfig storedConfig) {
153153
if (!tagsBuilder.toString().isEmpty()) {
154154
tagsBuilder.append(",");
155155
}
156+
tagsBuilder.append("is_crash:true").append(',');
156157
tagsBuilder.append(VersionInfo.LIBRARY_VERSION_TAG).append('=').append(VersionInfo.VERSION);
157158
// PID can be empty if we cannot find it out from the system
158159
if (!PidHelper.getPid().isEmpty()) {
@@ -446,7 +447,7 @@ private RequestBody makeTelemetryRequestBody(@Nonnull String payload, boolean is
446447
writer.name("tags").value(tagsForPing(storedConfig.reportUUID));
447448
} else {
448449
writer.name("level").value("ERROR");
449-
writer.name("tags").value("severity:crash");
450+
writer.name("tags").value("severity:crash,is_crash:true");
450451
writer.name("is_sensitive").value(true);
451452
writer.name("is_crash").value(true);
452453
}

‎dd-java-agent/agent-crashtracking/src/test/java/datadog/crashtracking/CrashUploaderTest.java‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ public void testLogsHappyPath() throws Exception {
103103
assertEquals(SERVICE, event.get("service").asText());
104104
assertEquals(CRASH, event.get("message").asText());
105105
assertEquals("ERROR", event.get("level").asText());
106+
assertTrue(event.get("ddtags").asText().contains("is_crash:true"));
106107
}
107108

108109
@Test
@@ -124,6 +125,7 @@ public void testExtractStackTraceFromRealCrashFile() throws IOException {
124125
assertEquals(
125126
readFileAsString("sample-stacktrace.txt"), event.get("error").get("stack").asText());
126127
assertEquals("ERROR", event.get("level").asText());
128+
assertTrue(event.get("ddtags").asText().contains("is_crash:true"));
127129
}
128130

129131
private String readFileAsString(String resource) throws IOException {
@@ -297,7 +299,7 @@ public void testTelemetryHappyPath(String log) throws Exception {
297299
assertThatJson(extracted.toJson())
298300
.whenIgnoringPaths("os_info", "metadata", "experimental")
299301
.isEqualTo(expected.toJson());
300-
assertEquals("severity:crash", event.get("payload").get(0).get("tags").asText());
302+
assertEquals("severity:crash,is_crash:true", event.get("payload").get(0).get("tags").asText());
301303
assertCommonPayload(event);
302304
}
303305

0 commit comments

Comments
 (0)