fix translation of string copy constructor

Author: nunoplopes

cpp2rust/converter/models/converter_refcount.cpp

@@ -2035,14 +2035,15 @@ bool ConverterRefCount::VisitCXXConstructExpr(clang::CXXConstructExpr *expr) {
 
   if (auto str = GetMappedAsString(expr, expr->getArgs(), expr->getNumArgs());
       !str.empty()) {
+    if (!IsPassThroughRule(expr)) {
+      MarkFresh();
+    }
     if (isAddrOf()) {
-      EmitFresh(std::format("Rc::new(RefCell::new({})){}", std::move(str),
+      EmitFresh(std::format("Rc::new(RefCell::new({})){}",
+                            MakeFresh(std::move(str)),
                             AsPointerMethod(expr->getType())));
     } else {
       StrCat(str);
-      if (!IsPassThroughRule(expr)) {
-        MarkFresh();
-      }
     }
     return false;
   }

tests/unit/out/refcount/string.rs

@@ -427,6 +427,10 @@ fn main_0() -> i32 {
         target.decay(),
         (*ref_calls.borrow())
     );
+    println!(
+        "copy: {}",
+        Rc::new(RefCell::new((*target.borrow()).clone())).decay()
+    );
     let targets: Value<Box<[Vec<i8>]>> = Rc::new(RefCell::new(Box::new([
         {
             let mut __bytes = Ptr::<i8>::from_string_literal(b"cd").to_c_bytes();

tests/unit/out/unsafe/string.rs

@@ -490,6 +490,12 @@ unsafe fn main_0() -> i32 {
             (ref_calls),
         )
     });
+    (unsafe {
+        libc::printf(
+            c"copy: %s\n".as_ptr() as *const libc::c_char,
+            (target.clone().as_ptr()),
+        )
+    });
     let mut targets: [Vec<libc::c_char>; 2] = [
         std::slice::from_raw_parts(
             c"cd".as_ptr(),

tests/unit/string.cpp

@@ -168,6 +168,7 @@ int main() {
   counted_ref(target, ref_calls).resize(1);
   counted_ref(target, ref_calls).at(0) = 'A';
   printf("reference receiver: %s %d\n", target.c_str(), ref_calls);
+  printf("copy: %s\n", std::string(target).c_str());
   std::string targets[2] = {"cd", "ef"};
   int target_index = 0;
   targets[target_index++].resize(1);