Change translation of string literal

In unsafe, they are translated as [u8; N] and in refcount they are
translated as Box<[u8]>.

Author: lucic71

cpp2rust/converter/converter.cpp

@@ -1706,11 +1706,13 @@ std::string Converter::GetEscapedStringLiteral(clang::Expr *expr,
 }
 
 bool Converter::VisitStringLiteral(clang::StringLiteral *expr) {
-  StrCat(std::format("b{}.as_ptr()", GetEscapedStringLiteral(expr, true)));
-  // In C, string literals are char[], in C++ they are const char[]
-  if (!expr->getType().isConstQualified()) {
-    StrCat(".cast_mut()");
+  if (!curr_init_type_.empty() && curr_init_type_.top()->isArrayType()) {
+    // b"" has type &static [u8; N]. For translating char str[] =
+    // "string_literal"; we need an initializer of type [u8; N]. Dereferencing
+    // the &static [u8; N] achieves this.
+    StrCat(token::kStar);
   }
+  StrCat(std::format("b{}", GetEscapedStringLiteral(expr, true)));
   return false;
 }
 

cpp2rust/converter/models/converter_refcount.cpp

@@ -946,6 +946,13 @@ bool ConverterRefCount::VisitCallExpr(clang::CallExpr *expr) {
 }
 
 bool ConverterRefCount::VisitStringLiteral(clang::StringLiteral *expr) {
+  if (!curr_init_type_.empty() && curr_init_type_.top()->isArrayType()) {
+    // b"" has type &static [u8; N]. For translating char str[] =
+    // "string_literal"; we need an initializer of type Box<[u8]>
+    StrCat(std::format("Box::<[u8]>::from(b{}.as_slice())",
+                       GetEscapedStringLiteral(expr, true)));
+    return false;
+  }
   StrCat(GetEscapedStringLiteral(expr));
   return false;
 }