Fix bool vector indexing (#573)

Author: lucic71

cpp2rust/converter/rules/expr_matcher.cpp

@@ -6,6 +6,7 @@
 #include <clang/AST/DeclCXX.h>
 #include <clang/AST/DeclTemplate.h>
 #include <clang/AST/ExprCXX.h>
+#include <clang/AST/IgnoreExpr.h>
 #include <clang/Basic/OperatorKinds.h>
 #include <clang/Lex/Lexer.h>
 #include <clang/Sema/EnterExpressionEvaluationContext.h>
@@ -160,7 +161,9 @@ std::vector<clang::Expr *> getOperands(clang::ASTContext &ctx,
     operands.assign(op->arg_begin(), op->arg_end());
     if (!operands.empty() &&
         llvm::isa_and_nonnull<clang::CXXMethodDecl>(op->getDirectCallee())) {
-      operands[0] = operands[0]->IgnoreParenImpCasts();
+      operands[0] =
+          clang::IgnoreExprNodes(operands[0], clang::IgnoreParensSingleStep,
+                                 clang::IgnoreImplicitCastsSingleStep);
     }
   } else if (auto call = llvm::dyn_cast<clang::CXXMemberCallExpr>(expr)) {
     operands.push_back(getObject(

tests/unit/out/refcount/vector_bool_reference.rs

@@ -26,6 +26,11 @@ fn main_0() -> i32 {
         (r2).clone()
     };
     assert!(v1.decay().offset(0_usize as isize).read());
+    {
+        v1.decay().offset(0_usize as isize).write(false);
+        v1.decay().offset(0_usize as isize)
+    };
+    assert!(!(v1.decay().offset(0_usize as isize).read()));
     return 0;
 }
 pub fn __cpp2rust_init_globals() {}

tests/unit/out/unsafe/vector_bool_reference.rs

@@ -28,6 +28,11 @@ unsafe fn main_0() -> i32 {
         r2
     };
     assert!(*(&mut (v1)[0_usize as usize] as *mut bool));
+    {
+        *(&mut (v1)[0_usize as usize] as *mut bool) = false;
+        (&mut (v1)[0_usize as usize] as *mut bool)
+    };
+    assert!(!(*(&mut (v1)[0_usize as usize] as *mut bool)));
     return 0;
 }
 pub unsafe fn __cpp2rust_init_globals() {}

tests/unit/vector_bool_reference.cpp

@@ -11,5 +11,7 @@ int main() {
   auto r2 = *it;
   r2 = true;
   assert(v1[0]);
+  v1[0] = false;
+  assert(!v1[0]);
   return 0;
 }