From a592dcdb6d9c46f75733605a85a4443f7b260ed9 Mon Sep 17 00:00:00 2001 From: Frumentius-Rev Date: Mon, 12 Oct 2026 10:28:04 +0100 Subject: [PATCH 1/5] Implemtnt angle type & test --- .../1-get-angle-type.test.js | 22 +++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js index cf50f6cad..96dd700f2 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js @@ -3,10 +3,28 @@ import test from "node:test"; import { getAngleType } from "../implement/1-get-angle-type.js"; -// TODO: Write tests to cover all cases, including boundary and invalid cases. -// Example: Identify Right Angles +test("Classifies acute angles", () => { + assert.equal(getAngleType(45), "Acute angle"); +}); test("Classifies right angles", () => { const right = getAngleType(90); assert.equal(right, "Right angle"); }); +test("Classifies obtuse angles", () => { + assert.equal(getAngleType(120), "Obtuse angle"); +}); + +test("Classifies straight angles", () => { + assert.equal(getAngleType(180), "Straight angle"); +}); + +test("Classifies reflex angles", () => { + assert.equal(getAngleType(270), "Reflex angle"); +}); + +test("Invalid angles", () => { + assert.equal(getAngleType(0), "Invalid angle"); + assert.equal(getAngleType(369), "Invalid angle"); + assert.equal(getAngleType(-10), "Invalid angle"); +}); From 152dbbbf93a62aa67b7c2f442efc357f75421c21 Mon Sep 17 00:00:00 2001 From: Frumentius-Rev Date: Mon, 12 Oct 2026 10:46:35 +0100 Subject: [PATCH 2/5] Implement angle type and tests --- .../implement/1-get-angle-type.js | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/implement-and-rewrite-tests/implement/1-get-angle-type.js b/implement-and-rewrite-tests/implement/1-get-angle-type.js index 8a6fba050..21898423d 100644 --- a/implement-and-rewrite-tests/implement/1-get-angle-type.js +++ b/implement-and-rewrite-tests/implement/1-get-angle-type.js @@ -17,5 +17,17 @@ // execute the code to ensure all tests pass. export function getAngleType(angle) { - // TODO: Implement this function + if (angle > 0 && angle < 90) { + return "Acute angle"; + } else if (angle === 90) { + return "Right angle"; + } else if (angle > 90 && angle < 180) { + return "Obtuse angle"; + } else if (angle === 180) { + return "Straight angle"; + } else if (angle > 180 && angle < 360) { + return "Reflex angle"; + } else { + return "Invalid angle"; + } } From da74f22cd5356910284ba02b7893059bd975f7cd Mon Sep 17 00:00:00 2001 From: Frumentius-Rev Date: Mon, 12 Oct 2026 11:44:11 +0100 Subject: [PATCH 3/5] Implement proper fraction & tests --- .../2-is-proper-fraction.test.js | 16 ++++++++++++++++ .../implement/2-is-proper-fraction.js | 2 +- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js index a29084605..6dbdd4d89 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js @@ -10,3 +10,19 @@ test("Basic proper fraction", () => { // Example: 1/2 is a proper fraction assert.equal(isProperFraction(1, 2), true); }); + +test("Basic proper fraction 2/5", () => { + assert.equal(isProperFraction(2, 5), true); +}); + +test("Basic proper fraction 3/5", () => { + assert.equal(isProperFraction(3, 5), true); +}); + +test("Checks equal numerator & denominator 5/5", () => { + assert.equal(isProperFraction(5, 5), false); +}); + +test("Checks numerator greater than denominator 7/5", () => { + assert.equal(isProperFraction(7, 5), false); +}); diff --git a/implement-and-rewrite-tests/implement/2-is-proper-fraction.js b/implement-and-rewrite-tests/implement/2-is-proper-fraction.js index f983800f0..0b4a4d686 100644 --- a/implement-and-rewrite-tests/implement/2-is-proper-fraction.js +++ b/implement-and-rewrite-tests/implement/2-is-proper-fraction.js @@ -14,5 +14,5 @@ // execute the code to ensure all tests pass. export function isProperFraction(numerator, denominator) { - // TODO: Implement this function + return numerator < denominator; } From 48b1a540816b30a347206f499792caff709cac0a Mon Sep 17 00:00:00 2001 From: Frumentius-Rev Date: Tue, 13 Oct 2026 14:42:17 +0100 Subject: [PATCH 4/5] Implement card value function & tests --- .../3-get-card-value.test.js | 28 +++++++++++++++-- .../implement/3-get-card-value.js | 31 ++++++++++++++++++- 2 files changed, 55 insertions(+), 4 deletions(-) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js index f5092d9b1..0b19d5239 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js @@ -3,14 +3,36 @@ import test from "node:test"; import { getCardValue } from "../implement/3-get-card-value.js"; -// TODO: Write tests to cover all outcomes, including throwing errors for invalid cards. +test("Ace returns 11", () => { + assert.equal(getCardValue("A♠"), 11); +}); + +test("Face cards returns 10", () => { + assert.equal(getCardValue("J♣"), 10); + assert.equal(getCardValue("Q♦"), 10); + assert.equal(getCardValue("K♥"), 10); +}); + +test("Number cards return their numerical value", () => { + assert.equal(getCardValue("2♥"), 2); + assert.equal(getCardValue("10♥"), 10); +}); test("Valid single-digit card", () => { assert.equal(getCardValue("9♠"), 9); }); test("Arbitrary non-card string", () => { - assert.throws(() => getCardValue("invalid"), /Expected a number followed by a suit, but got "invalid"/, "Expected clear error"); + assert.throws( + () => getCardValue("invalid"), + /Expected a number followed by a suit, but got "invalid"/, + "Expected clear error" + ); }); -// TODO: What other invalid card cases can you think of? +test("Invalid suit throws an error", () => { + assert.throws( + () => getCardValue("9X"), + /Expected a number followed by a suit, but got "9X"/ + ); +}); diff --git a/implement-and-rewrite-tests/implement/3-get-card-value.js b/implement-and-rewrite-tests/implement/3-get-card-value.js index 9614ab1ee..625f24251 100644 --- a/implement-and-rewrite-tests/implement/3-get-card-value.js +++ b/implement-and-rewrite-tests/implement/3-get-card-value.js @@ -24,5 +24,34 @@ // execute the code to ensure all tests pass. export function getCardValue(card) { - // TODO: Implement this function + const rank = card.slice(0, -1); + const suit = card.slice(-1); + + const validRanks = [ + "A", + "2", + "3", + "4", + "5", + "6", + "7", + "8", + "9", + "10", + "J", + "Q", + "K", + ]; + const validSuits = ["♠", "♥", "♦", "♣"]; + + if (!validRanks.includes(rank) || !validSuits.includes(suit)) { + throw new Error(`Expected a number followed by a suit, but got "${card}"`); + } + if (rank === "A") { + return 11; + } else if (rank === "J" || rank === "Q" || rank === "K") { + return 10; + } else { + return Number(rank); + } } From 97ae1f5dcb0841413494d8f791ce2a01d9c501cf Mon Sep 17 00:00:00 2001 From: Frumentius-Rev Date: Tue, 13 Oct 2026 17:22:06 +0100 Subject: [PATCH 5/5] Complete Jest tests --- .../1-get-angle-type.test.js | 22 +++++++++++++++++++ .../2-is-proper-fraction.test.js | 13 +++++++++++ .../3-get-card-value.test.js | 21 ++++++++++++++++-- 3 files changed, 54 insertions(+), 2 deletions(-) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js index e0ba786ab..048f31139 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js @@ -3,6 +3,28 @@ import { getAngleType } from "../implement/1-get-angle-type.js"; // TODO: Write tests in Jest syntax to cover all cases/outcomes, // including boundary and invalid cases. +test("90 degrees is a right angle", () => { + expect(getAngleType(90)).toEqual("Right angle"); +}); + +test("obtuse angle", () => { + expect(getAngleType(120)).toEqual("Obtuse angle"); +}); + +test("180 degrees is a straight angle", () => { + expect(getAngleType(180)).toEqual("Straight angle"); +}); + +test("Reflex angle", () => { + expect(getAngleType(270)).toEqual("Reflex angle"); +}); + +test("Invalid angle", () => { + expect(getAngleType(0)).toEqual("Invalid angle"); + expect(getAngleType(360)).toEqual("Invalid angle"); + expect(getAngleType(-10)).toEqual("Invalid angle"); +}); + // Case 1: Acute angles test(`should return "Acute angle" when (0 < angle < 90)`, () => { // Test various acute angles, including boundary cases diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js index 5d49e2d8b..c920e6755 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js @@ -1,8 +1,21 @@ import { isProperFraction } from "../implement/2-is-proper-fraction.js"; // TODO: Write tests in Jest syntax to cover all combinations of positives, negatives, zeros, and other categories. +test(`should return true for proper fractions`, () => { + expect(isProperFraction(1, 2)).toEqual(true); + expect(isProperFraction(2, 5)).toEqual(true); +}); + +test(`should return false when numerator is not smaller`, () => { + expect(isProperFraction(5, 5)).toEqual(false); + expect(isProperFraction(7, 5)).toEqual(false); +}); // Special case: numerator is zero test(`should return false when denominator is zero`, () => { expect(isProperFraction(1, 0)).toEqual(false); }); + +test(`should return true when numerator is zero`, () => { + expect(isProperFraction(0, 5)).toEqual(true); +}); diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js index a6de5a82a..9292e3640 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js @@ -1,12 +1,30 @@ import { getCardValue } from "../implement/3-get-card-value.js"; -// TODO: Write tests in Jest syntax to cover all possible outcomes. +test("Should return 2 for a number card", () => { + expect(getCardValue("2♥")).toEqual(2); +}); + +test("Number card (2-10)", () => { + expect(getCardValue("7♦")).toEqual(7); + expect(getCardValue("4♣")).toEqual(4); +}); + +test("Face Cards (J, Q, K)", () => { + expect(getCardValue("J♣")).toEqual(10); + expect(getCardValue("Q♦")).toEqual(10); + expect(getCardValue("K♥")).toEqual(10); +}); // Case 1: Ace (A) test(`Should return 11 when given an ace card`, () => { expect(getCardValue("A♠")).toEqual(11); }); +test("Invalid cards throw an error", () => { + expect(() => getCardValue("2x")).toThrow(); + expect(() => getCardValue(invalid)).toThrow(); +}); + // Suggestion: Group the remaining test data into these categories: // Number Cards (2-10) // Face Cards (J, Q, K) @@ -15,4 +33,3 @@ test(`Should return 11 when given an ace card`, () => { // To learn how to test whether a function throws an error as expected in Jest, // please refer to the Jest documentation: // https://jestjs.io/docs/expect#tothrowerror -