add Math.abs for negative value

Author: shirinpanahian

implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js

@@ -20,3 +20,18 @@ test("Equal numerator and denominator", () => {
   // Example: equal number
   assert.equal(isProperFraction(5, 5), false);
 });
+
+test("zero numerator", () => {
+  // Example: zero numerator is a proper fraction?
+  assert.equal(isProperFraction(0, 6), true);
+});
+
+test("Negative numerator", () => {
+  // Example: negative numerator is a proper fraction?
+  assert.equal(isProperFraction(-2, 3), true);
+});
+
+test("Negative denominator", () => {
+  // Example: negative numerator is a proper fraction?
+  assert.equal(isProperFraction(2, -5), true);
+});

implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -15,7 +15,7 @@
 
 export function isProperFraction(numerator, denominator) {
   // TODO: Implement this function
-  if (numerator < denominator) {
+  if (Math.abs(numerator) < Math.abs(denominator)) {
     return true;
   }
   return false;