simplify function

Author: shirinpanahian

implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js

@@ -32,7 +32,7 @@ test("Negative numerator", () => {
 });
 
 test("Negative denominator", () => {
-  // Example: negative numerator is a proper fraction?
+  // Example: negative denominator is a proper fraction?
   assert.equal(isProperFraction(2, -5), true);
 });
 
@@ -41,3 +41,18 @@ test("Both negative", () => {
   assert.equal(isProperFraction(-3, -5), true);
   assert.equal(isProperFraction(-5, -2), false);
 });
+
+test("Zero denominator", () => {
+  // Example: Zero denominator is a proper fraction?
+  assert.equal(isProperFraction(7, 0), false);
+});
+
+test("Zero numerator and negative denominator", () => {
+  // Example: Zero numerator and negative denominator is a proper fraction?
+  assert.equal(isProperFraction(0, -7), true);
+});
+
+test("Both Zero", () => {
+  // Example: Both Zero is a proper fraction?
+  assert.equal(isProperFraction(0, 0), false);
+});

implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -15,8 +15,5 @@
 
 export function isProperFraction(numerator, denominator) {
   // TODO: Implement this function
-  if (Math.abs(numerator) < Math.abs(denominator)) {
-    return true;
-  }
-  return false;
+  return Math.abs(numerator) < Math.abs(denominator);
 }