Skip to content

Commit 23c6ee7

Browse files
committed
made change to include any value under 1 to be Incorrect card number given.
1 parent e6b8b53 commit 23c6ee7

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

‎implement-and-rewrite-tests/implement/3-get-card-value.js‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,21 +25,23 @@
2525

2626
export function getCardValue(card) {
2727
// TODO: Implement this function
28+
if (card.length >= 4) {
29+
throw new Error(`Expected a number followed by a suit, but got "invalid"`);
30+
}
31+
2832
let suit = card.slice(-1);
2933
let cardNumber = card.slice(0, -1);
3034
let value = Number(cardNumber);
3135

32-
if (card.length >= 4) {
33-
throw new Error(`Expected a number followed by a suit, but got "invalid"`);
34-
} else if (!(suit === "♠" || suit === "♥" || suit === "♦" || suit === "♣")) {
36+
if (!(suit === "♠" || suit === "♥" || suit === "♦" || suit === "♣")) {
3537
throw new Error("Incorrect suit given");
3638
} else if (cardNumber === "J" || cardNumber === "Q" || cardNumber === "K") {
3739
return 10;
3840
} else if (cardNumber === "A") {
3941
return 11;
4042
} else if (value >= 2 && value <= 10) {
4143
return value;
42-
} else if (Value > 10) {
44+
} else if (value < 2 || value > 10) {
4345
throw new Error("Incorrect card number given");
4446
}
4547
}

0 commit comments

Comments
 (0)