Skip to content

Commit b862d6d

Browse files
committed
Predict and explain errors. Fix by removing line and making variable outside function
1 parent 38c5f48 commit b862d6d

1 file changed

Lines changed: 28 additions & 6 deletions

File tree

  • Sprint-3/1-key-errors

‎Sprint-3/1-key-errors/1.js‎

Lines changed: 28 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,41 @@
22

33
// Why will an error occur when this program runs?
44
// =============> write your prediction here
5+
//decimalNumber already exists as a parameter, so const decimalNumber is making
6+
//a new variable with the same name. There is also a problem where decimalNumber is being
7+
//assigned 0.5, which won't cause errors, but means that no matter what is passed to the function
8+
//decimalNumber will always be 0.5
59

610
// Try playing computer with the example to work out what is going on
711

8-
function convertToPercentage(decimalNumber) {
9-
const decimalNumber = 0.5;
10-
const percentage = `${decimalNumber * 100}%`;
12+
//function convertToPercentage(decimalNumber) {
13+
// const percentage = `${decimalNumber * 100}%`;
1114

12-
return percentage;
13-
}
15+
// return percentage;
16+
//}
1417

15-
console.log(decimalNumber);
18+
//convertToPercentage(0.6)
19+
//console.log(decimalNumber);
1620

1721
// =============> write your explanation here
22+
//SyntaxError: Identifier 'decimalNumber' has already been declared
23+
//prediction correct, decimalNumber already exists so causes error. Removing the line
24+
//shows another error
25+
//console.log(decimalNumber);
26+
// ^
27+
//ReferenceError: decimalNumber is not defined
28+
//This is because of scope, decimalNumber is defined in the function, so it only has scope
29+
//in the function
1830

1931
// Finally, correct the code to fix the problem
2032
// =============> write your new code here
33+
34+
function convertToPercentage(decimalNumber) {
35+
const percentage = `${decimalNumber * 100}%`;
36+
37+
return percentage;
38+
}
39+
40+
let decimalNumber = 0.6;
41+
console.log(decimalNumber);
42+
console.log(convertToPercentage(decimalNumber));

0 commit comments

Comments
 (0)