From cfd4ac19b68549eccd15530a5413176b6f6ed850 Mon Sep 17 00:00:00 2001 From: Mouawia Elkhalifa Date: Thu, 9 Apr 2026 19:58:16 +0100 Subject: [PATCH 1/2] book library project --- debugging/book-library/index.html | 2 +- debugging/book-library/script.js | 88 +++++++++++++------------------ 2 files changed, 39 insertions(+), 51 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa71..bb392dfc 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -65,7 +65,7 @@

Library

type="submit" value="Submit" class="btn btn-primary" - onclick="submit();" + onclick="addBook();" /> diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1d..686da8bf 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,23 +1,17 @@ let myLibrary = []; -window.addEventListener("load", function (e) { +window.addEventListener("load", function () { populateStorage(); - render(); }); function populateStorage() { - if (myLibrary.length == 0) { - let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); - let book2 = new Book( - "The Old Man and the Sea", - "Ernest Hemingway", - "127", - true + if (myLibrary.length === 0) { + myLibrary.push( + new Book("Robinson Crusoe", "Daniel Defoe", 252, true), + new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true) ); - myLibrary.push(book1); - myLibrary.push(book2); - render(); } + render(); } const title = document.getElementById("title"); @@ -25,22 +19,22 @@ const author = document.getElementById("author"); const pages = document.getElementById("pages"); const check = document.getElementById("check"); -//check the right input from forms and if its ok -> add the new book (object in array) -//via Book function and start render function -function submit() { - if ( - title.value == null || - title.value == "" || - pages.value == null || - pages.value == "" - ) { +function addBook() { + if (!title.value || !author.value || !pages.value) { alert("Please fill all fields!"); - return false; - } else { - let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); - render(); + return; } + + myLibrary.push( + new Book(title.value, author.value, pages.value, check.checked) + ); + + title.value = ""; + author.value = ""; + pages.value = ""; + check.checked = false; + + render(); } function Book(title, author, pages, check) { @@ -53,51 +47,45 @@ function Book(title, author, pages, check) { function render() { let table = document.getElementById("display"); let rowsNumber = table.rows.length; - //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { + + + for (let n = rowsNumber - 1; n > 0; n--) { table.deleteRow(n); } - //insert updated row and cells - let length = myLibrary.length; - for (let i = 0; i < length; i++) { - let row = table.insertRow(1); + + for (let i = 0; i < myLibrary.length; i++) { + let row = table.insertRow(-1); + let titleCell = row.insertCell(0); let authorCell = row.insertCell(1); let pagesCell = row.insertCell(2); let wasReadCell = row.insertCell(3); let deleteCell = row.insertCell(4); + titleCell.innerHTML = myLibrary[i].title; authorCell.innerHTML = myLibrary[i].author; pagesCell.innerHTML = myLibrary[i].pages; - //add and wait for action for read/unread button let changeBut = document.createElement("button"); - changeBut.id = i; changeBut.className = "btn btn-success"; - wasReadCell.appendChild(changeBut); - let readStatus = ""; - if (myLibrary[i].check == false) { - readStatus = "Yes"; - } else { - readStatus = "No"; - } - changeBut.innerText = readStatus; + changeBut.innerText = myLibrary[i].check ? "Yes" : "No"; changeBut.addEventListener("click", function () { myLibrary[i].check = !myLibrary[i].check; render(); }); - //add delete button to every row and render again - let delButton = document.createElement("button"); - delBut.id = i + 5; - deleteCell.appendChild(delBut); + wasReadCell.appendChild(changeBut); + + let delBut = document.createElement("button"); delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { - alert(`You've deleted title: ${myLibrary[i].title}`); + delBut.innerText = "Delete"; + + delBut.addEventListener("click", function () { myLibrary.splice(i, 1); render(); }); + + deleteCell.appendChild(delBut); } -} +} \ No newline at end of file From de1d05f6dd0962481f8e963e6c76515c426b5d6c Mon Sep 17 00:00:00 2001 From: Mouawia Elkhalifa Date: Fri, 10 Apr 2026 08:35:20 +0100 Subject: [PATCH 2/2] update: implement final code improvements and optimizations --- debugging/book-library/index.html | 129 +++++++++++------------------- debugging/book-library/script.js | 107 ++++++++++++------------- debugging/book-library/style.css | 7 +- 3 files changed, 104 insertions(+), 139 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index bb392dfc..a84b9645 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,96 +1,63 @@ - + - - + Book Library + + + + - - + + -
-

Library

-

Add books to your virtual library

-
+
+
+

Library

+

Add books to your virtual library

+
- + -
-
- - - - - - - - +
+
+ + + + + + + + + + + + +
-
- - - - - - - - - - - - - - - - - - - -
TitleAuthorNumber of PagesRead
+ + + + + + + + + + + + +
TitleAuthorNumber of PagesRead
+
- + \ No newline at end of file diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 686da8bf..dcade382 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -14,28 +14,10 @@ function populateStorage() { render(); } -const title = document.getElementById("title"); -const author = document.getElementById("author"); -const pages = document.getElementById("pages"); -const check = document.getElementById("check"); - -function addBook() { - if (!title.value || !author.value || !pages.value) { - alert("Please fill all fields!"); - return; - } - - myLibrary.push( - new Book(title.value, author.value, pages.value, check.checked) - ); - - title.value = ""; - author.value = ""; - pages.value = ""; - check.checked = false; - - render(); -} +const titleInput = document.getElementById("title"); +const authorInput = document.getElementById("author"); +const pagesInput = document.getElementById("pages"); +const checkInput = document.getElementById("check"); function Book(title, author, pages, check) { this.title = title; @@ -44,48 +26,65 @@ function Book(title, author, pages, check) { this.check = check; } -function render() { - let table = document.getElementById("display"); - let rowsNumber = table.rows.length; - +function addBook() { + const titleValue = titleInput.value.trim(); + const authorValue = authorInput.value.trim(); + const pagesValue = parseInt(pagesInput.value); - for (let n = rowsNumber - 1; n > 0; n--) { - table.deleteRow(n); + if (!titleValue || !authorValue || isNaN(pagesValue)) { + alert("Please fill all fields with valid information!"); + return; } - for (let i = 0; i < myLibrary.length; i++) { - let row = table.insertRow(-1); - - let titleCell = row.insertCell(0); - let authorCell = row.insertCell(1); - let pagesCell = row.insertCell(2); - let wasReadCell = row.insertCell(3); - let deleteCell = row.insertCell(4); + myLibrary.push( + new Book(titleValue, authorValue, pagesValue, checkInput.checked) + ); - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; + titleInput.value = ""; + authorInput.value = ""; + pagesInput.value = ""; + checkInput.checked = false; - let changeBut = document.createElement("button"); - changeBut.className = "btn btn-success"; - changeBut.innerText = myLibrary[i].check ? "Yes" : "No"; + render(); +} - changeBut.addEventListener("click", function () { - myLibrary[i].check = !myLibrary[i].check; +function render() { + const tableBody = document.querySelector("#display tbody"); + tableBody.innerHTML = ""; + + myLibrary.forEach((book, index) => { + const row = tableBody.insertRow(); + + const titleCell = row.insertCell(0); + const authorCell = row.insertCell(1); + const pagesCell = row.insertCell(2); + const wasReadCell = row.insertCell(3); + const actionCell = row.insertCell(4); + + titleCell.textContent = book.title; + authorCell.textContent = book.author; + pagesCell.textContent = book.pages; + + const changeBtn = document.createElement("button"); + changeBtn.className = "btn btn-success"; + changeBtn.textContent = book.check ? "Yes" : "No"; + changeBtn.setAttribute("aria-label", `Change read status for ${book.title}`); + changeBtn.addEventListener("click", () => { + book.check = !book.check; render(); }); - wasReadCell.appendChild(changeBut); - - let delBut = document.createElement("button"); - delBut.className = "btn btn-warning"; - delBut.innerText = "Delete"; - - delBut.addEventListener("click", function () { - myLibrary.splice(i, 1); + const deleteBtn = document.createElement("button"); + deleteBtn.className = "btn btn-warning"; + deleteBtn.textContent = "Delete"; + deleteBtn.setAttribute("aria-label", `Delete ${book.title}`); + deleteBtn.addEventListener("click", () => { + myLibrary.splice(index, 1); render(); + setTimeout(() => alert(`Deleted: ${book.title}`), 100); }); - deleteCell.appendChild(delBut); - } + wasReadCell.appendChild(changeBtn); + actionCell.appendChild(deleteBtn); + }); } \ No newline at end of file diff --git a/debugging/book-library/style.css b/debugging/book-library/style.css index 302950cb..4e8b7020 100644 --- a/debugging/book-library/style.css +++ b/debugging/book-library/style.css @@ -1,7 +1,5 @@ .form-group { width: 400px; - height: 300px; - align-self: left; padding-left: 20px; } @@ -11,9 +9,10 @@ .form-check-label { padding-left: 20px; - margin: 5px 0px 5px 0px; + margin: 5px 0; + display: block; } button.btn-info { margin: 20px; -} +} \ No newline at end of file