diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa71..9a605564 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,20 +1,20 @@ - + - - + + + + Library + + - + > + @@ -27,50 +27,51 @@

Library

Add new book -
-
+
+
- + > + + - + > + + -
+ + +
- +
@@ -80,17 +81,9 @@

Library

- - - - - - - - - +
Title
- + - + \ No newline at end of file diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1d..428ae5b6 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,103 +1,111 @@ -let myLibrary = []; +const myLibrary = []; -window.addEventListener("load", function (e) { - populateStorage(); +window.addEventListener("load", () => { + populateLibrary(); render(); }); -function populateStorage() { - if (myLibrary.length == 0) { - let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); - let book2 = new Book( - "The Old Man and the Sea", - "Ernest Hemingway", - "127", - true - ); - myLibrary.push(book1); - myLibrary.push(book2); - render(); +function populateLibrary() { + if (myLibrary.length !== 0) { + return; } + + myLibrary.push( + new Book("Robinson Crusoe", "Daniel Defoe", 252, true), + new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true) + ); } -const title = document.getElementById("title"); -const author = document.getElementById("author"); -const pages = document.getElementById("pages"); -const check = document.getElementById("check"); +const titleInput = document.getElementById("title"); +const authorInput = document.getElementById("author"); +const pagesInput = document.getElementById("pages"); +const readCheckbox = document.getElementById("check"); +const tableBody = document.querySelector("#display tbody"); -//check the right input from forms and if its ok -> add the new book (object in array) -//via Book function and start render function function submit() { - if ( - title.value == null || - title.value == "" || - pages.value == null || - pages.value == "" - ) { - alert("Please fill all fields!"); - return false; - } else { - let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); - render(); + // .value is always a string, never null + const title = titleInput.value.trim(); + const author = authorInput.value.trim(); + const pages = Number(pagesInput.value); + + // Reject empty strings, whitespace-only strings, invalid page counts + if (title === "" || author === "") { + alert("Title and author cannot be empty."); + return; } + + if (!Number.isInteger(pages) || pages <= 0) { + alert("Page count must be a positive whole number."); + return; + } + + myLibrary.push( + new Book(title, author, pages, readCheckbox.checked) + ); + + render(); } -function Book(title, author, pages, check) { +function Book(title, author, pages, hasRead) { this.title = title; this.author = author; this.pages = pages; - this.check = check; + this.hasRead = hasRead; } function render() { - let table = document.getElementById("display"); - let rowsNumber = table.rows.length; - //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { - table.deleteRow(n); - } - //insert updated row and cells - let length = myLibrary.length; - for (let i = 0; i < length; i++) { - let row = table.insertRow(1); - let titleCell = row.insertCell(0); - let authorCell = row.insertCell(1); - let pagesCell = row.insertCell(2); - let wasReadCell = row.insertCell(3); - let deleteCell = row.insertCell(4); - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; - - //add and wait for action for read/unread button - let changeBut = document.createElement("button"); - changeBut.id = i; - changeBut.className = "btn btn-success"; - wasReadCell.appendChild(changeBut); - let readStatus = ""; - if (myLibrary[i].check == false) { - readStatus = "Yes"; - } else { - readStatus = "No"; - } - changeBut.innerText = readStatus; - - changeBut.addEventListener("click", function () { - myLibrary[i].check = !myLibrary[i].check; + // Clear all existing rows in one operation + tableBody.textContent = ""; + + myLibrary.forEach((book, index) => { + const row = document.createElement("tr"); + + const titleCell = document.createElement("td"); + titleCell.textContent = book.title; + + const authorCell = document.createElement("td"); + authorCell.textContent = book.author; + + const pagesCell = document.createElement("td"); + pagesCell.textContent = book.pages; + + const readCell = document.createElement("td"); + const toggleReadButton = document.createElement("button"); + toggleReadButton.className = "btn btn-success"; + toggleReadButton.textContent = book.hasRead ? "Yes" : "No"; + + toggleReadButton.addEventListener("click", () => { + book.hasRead = !book.hasRead; render(); }); - //add delete button to every row and render again - let delButton = document.createElement("button"); - delBut.id = i + 5; - deleteCell.appendChild(delBut); - delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { - alert(`You've deleted title: ${myLibrary[i].title}`); - myLibrary.splice(i, 1); + readCell.appendChild(toggleReadButton); + + const deleteCell = document.createElement("td"); + const deleteButton = document.createElement("button"); + deleteButton.className = "btn btn-warning"; + deleteButton.textContent = "Delete"; + + deleteButton.addEventListener("click", () => { + const deletedTitle = book.title; + + myLibrary.splice(index, 1); render(); + + alert(`Deleted: ${deletedTitle}`); }); - } + + deleteCell.appendChild(deleteButton); + + row.append( + titleCell, + authorCell, + pagesCell, + readCell, + deleteCell + ); + + tableBody.appendChild(row); + }); } +