Skip to content

Commit d32fa30

Browse files
authored
Revert "Arm backend: Fix Buck dependencies for Vulkan headers (pytorch#22601)" (pytorch#22914)
Reverts pytorch#22601 (`4307b1c`). ▎ Reverts pytorch#22601. The dep swap breaks the internal Arm backend build: backends/arm/runtime/VGFNeuralStatistics.h:16 includes <executorch/backends/vulkan/runtime/vk_api/vk_api.h>, which the previous vulkan-headers-1.4.343 targets supplied transitively but third-party/volk:volk-header + third-party/khronos:vulkan-headers do not. 157 executorch/backends/arm/test:* targets fail to build with vk_api.h file not found. Re-landing will need an explicit dep on the target cc @wwwind
1 parent 56dc50b commit d32fa30

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

‎backends/arm/runtime/targets.bzl‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def define_common_targets():
4646
# function-pointer variables live in the same linkage unit.
4747
# Linking from a separate static library causes the linker to
4848
# drop the symbols when building a shared library.
49-
"fbsource//third-party/volk:volk_src",
49+
"fbsource//third-party/vulkan-headers-1.4.343/v1.4.343/src:volk_arm_src",
5050
],
5151
exported_headers = [
5252
"VGFNeuralStatistics.h",
@@ -69,7 +69,7 @@ def define_common_targets():
6969
"//executorch/runtime/backend:interface",
7070
"//executorch/runtime/core:core",
7171
"fbsource//third-party/arm-vgf-library/v0.9.0/src:vgf",
72-
"fbsource//third-party/volk:volk-header",
73-
"fbsource//third-party/khronos:vulkan-headers",
72+
"fbsource//third-party/vulkan-headers-1.4.343/v1.4.343/src:volk_arm",
73+
"fbsource//third-party/vulkan-headers-1.4.343/v1.4.343/src:vulkan-headers",
7474
],
7575
)

0 commit comments

Comments
 (0)