Skip to content

Commit e2f8a71

Browse files
fix: use stable PR route for webview links (#75)
The review-comment webview link appended ?run=<run_id>, pinning the link to one workflow run. The webview resolves the repo/PR's latest artifact itself, so link the bare /{owner}/{repo}/pull/{pr} route, which stays valid across runs. Merging this fix-typed commit also makes release-please cut the release that finally ships the CodeBoarding 0.13.8 engine pin (it landed on main as a chore commit after v1.10.2, so it was never released). Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
1 parent e5cedbf commit e2f8a71

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

‎scripts/action/build-review-comment.sh‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@ if [ "$N_CHANGED" = "1" ]; then
66
COMPONENT_NOUN="component"
77
fi
88
RUN_URL="${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}"
9-
WEBVIEW_URL="https://app.codeboarding.org/${GITHUB_REPOSITORY}/pull/${PR_NUMBER}?run=${GITHUB_RUN_ID}"
9+
# Stable PR route: the webview resolves the repo/PR's latest artifact itself,
10+
# so the link stays valid across runs instead of pinning one run id.
11+
WEBVIEW_URL="https://app.codeboarding.org/${GITHUB_REPOSITORY}/pull/${PR_NUMBER}"
1012
BODY="${RUNNER_TEMP}/review-comment.md"
1113
printf '### CodeBoarding review\n\n**Status:** %s changed %s\n' "$N_CHANGED" "$COMPONENT_NOUN" > "$BODY"
1214
printf '\nSee the full change in [CodeBoarding](%s).\n' "$WEBVIEW_URL" >> "$BODY"

0 commit comments

Comments
 (0)