chore: clear CI warnings

- bump `actions/setup-node` and `pnpm/action-setup` to the majors that run
  on Node 24, the runners now warn about the Node 20 based ones
- use the `simulation` runner mode in the example matrix, `instrumentation`
  is deprecated
- widen the root `engines.node` to `>=22`, the exact pin made every Node 22
  example job print an unsupported engine warning
- pass `sourceMap`/`outputToFilesystem` to the rollup config plugin, which
  otherwise warns while compiling `rollup.config.ts`
- move the runner mode helpers to their own module: `introspection.ts`
  imported them from the barrel file, so rollup reported a cycle
- ignore the `EVAL` warning for `optimization.ts`, %OptimizeFunctionOnNextCall
  has no non-eval entry point
- build the symbol names with `v8::String::Utf8Value`, `Utf8Length` and
  `WriteUtf8` are deprecated as of the V8 shipped with Node 24

Author: not-matthias

.eslintrc.json

@@ -9,7 +9,7 @@
   "ignorePatterns": [
     "**/dist/**",
     "**/node_modules/**",
-    "**/rollup.config.ts",
+    "**/rollup.config.mjs",
     "**/jest.config.js",
     "packages/core/src/native_core/instruments/hooks/**"
   ],

.github/workflows/ci.yml

@@ -17,8 +17,8 @@ jobs:
         with:
           fetch-depth: 0
           submodules: true
-      - uses: pnpm/action-setup@v2
-      - uses: actions/setup-node@v3
+      - uses: pnpm/action-setup@v4
+      - uses: actions/setup-node@v6
         with:
           cache: pnpm
           node-version-file: .nvmrc
@@ -57,8 +57,8 @@ jobs:
         with:
           fetch-depth: 0
           submodules: true
-      - uses: pnpm/action-setup@v2
-      - uses: actions/setup-node@v3
+      - uses: pnpm/action-setup@v4
+      - uses: actions/setup-node@v6
         with:
           cache: pnpm
           node-version: ${{ matrix.node-version }}
@@ -73,7 +73,7 @@ jobs:
         # use version from `main` branch to always test the latest version, in real projects, use a tag, like `@v2`
         uses: CodSpeedHQ/action@main
         with:
-          mode: instrumentation
+          mode: simulation
           run: pnpm --filter ${{ matrix.example }} bench-tinybench
         env:
           CODSPEED_SKIP_UPLOAD: true
@@ -82,7 +82,7 @@ jobs:
         # use version from `main` branch to always test the latest version, in real projects, use a tag, like `@v2`
         uses: CodSpeedHQ/action@main
         with:
-          mode: instrumentation
+          mode: simulation
           run: pnpm --filter ${{ matrix.example }} bench-benchmark-js
         env:
           CODSPEED_SKIP_UPLOAD: true

.github/workflows/codspeed.yml

@@ -37,8 +37,8 @@ jobs:
         with:
           fetch-depth: 0
           submodules: true
-      - uses: pnpm/action-setup@v2
-      - uses: actions/setup-node@v3
+      - uses: pnpm/action-setup@v4
+      - uses: actions/setup-node@v6
         with:
           cache: pnpm
           node-version-file: .nvmrc
@@ -69,8 +69,8 @@ jobs:
         with:
           fetch-depth: 0
           submodules: true
-      - uses: pnpm/action-setup@v2
-      - uses: actions/setup-node@v3
+      - uses: pnpm/action-setup@v4
+      - uses: actions/setup-node@v6
         with:
           cache: pnpm
           node-version-file: .nvmrc
@@ -100,8 +100,8 @@ jobs:
         with:
           fetch-depth: 0
           submodules: true
-      - uses: pnpm/action-setup@v2
-      - uses: actions/setup-node@v3
+      - uses: pnpm/action-setup@v4
+      - uses: actions/setup-node@v6
         with:
           cache: pnpm
           node-version-file: .nvmrc

.github/workflows/release.yml

@@ -28,8 +28,8 @@ jobs:
         with:
           fetch-depth: 0
           submodules: true
-      - uses: pnpm/action-setup@v2
-      - uses: actions/setup-node@v3
+      - uses: pnpm/action-setup@v4
+      - uses: actions/setup-node@v6
         with:
           cache: pnpm
           node-version-file: .nvmrc
@@ -51,8 +51,8 @@ jobs:
         with:
           fetch-depth: 0
           submodules: true
-      - uses: pnpm/action-setup@v2
-      - uses: actions/setup-node@v3
+      - uses: pnpm/action-setup@v4
+      - uses: actions/setup-node@v6
         with:
           cache: pnpm
           node-version-file: .nvmrc

package.json

@@ -48,6 +48,6 @@
     }
   },
   "engines": {
-    "node": "24.19.0"
+    "node": ">=22"
   }
 }

packages/benchmark.js-plugin/package.json

@@ -15,7 +15,7 @@
     "dist"
   ],
   "scripts": {
-    "build": "NODE_NO_WARNINGS=1 rollup -c rollup.config.ts --configPlugin typescript --configImportAttributesKey with",
+    "build": "rollup -c",
     "test": "jest --passWithNoTests --silent",
     "test/integ": "jest --passWithNoTests --silent -c jest.config.integ.js",
     "lint": "eslint .",

…ges/benchmark.js-plugin/rollup.config.ts …es/benchmark.js-plugin/rollup.config.mjspackages/benchmark.js-plugin/rollup.config.ts renamed to packages/benchmark.js-plugin/rollup.config.mjs packages/benchmark.js-plugin/rollup.config.ts renamed to packages/benchmark.js-plugin/rollup.config.mjs

@@ -1,5 +1,5 @@
 import { defineConfig } from "rollup";
-import { declarationsPlugin, jsPlugins } from "../../rollup.options";
+import { declarationsPlugin, jsPlugins } from "../../rollup.options.mjs";
 import pkg from "./package.json" with { type: "json" };
 
 const entrypoint = "src/index.ts";

packages/core/package.json

@@ -16,7 +16,7 @@
   "types": "dist/index.d.ts",
   "gypfile": true,
   "scripts": {
-    "build": "NODE_NO_WARNINGS=1 rollup -c rollup.config.ts --configPlugin typescript --configImportAttributesKey with",
+    "build": "rollup -c",
     "build-native-addon": "prebuildify --name node --strip --no-napi --target 22.0.0 --target 24.0.0",
     "build-tracer-client": "openapi --client axios --input ./tracer.spec.json --name MongoTracer --output ./src/generated/openapi",
     "test": "jest --passWithNoTests --silent",

packages/core/rollup.config.ts packages/core/rollup.config.mjspackages/core/rollup.config.ts renamed to packages/core/rollup.config.mjs

@@ -1,5 +1,5 @@
 import { defineConfig } from "rollup";
-import { declarationsPlugin, jsPlugins } from "../../rollup.options";
+import { declarationsPlugin, jsPlugins } from "../../rollup.options.mjs";
 import pkg from "./package.json" with { type: "json" };
 
 const entrypoint = "src/index.ts";
@@ -27,5 +27,13 @@ export default defineConfig([
       { file: pkg.module, format: "es", sourcemap: true },
     ],
     plugins: jsPlugins(pkg.version),
+    onwarn(warning, warn) {
+      // The optimization helpers reach V8 natives syntax
+      // (%OptimizeFunctionOnNextCall), which has no non-eval entry point.
+      if (warning.code === "EVAL" && warning.id?.endsWith("optimization.ts")) {
+        return;
+      }
+      warn(warning);
+    },
   },
 ]);

packages/core/src/index.ts

@@ -1,6 +1,7 @@
 import { checkV8Flags } from "./introspection";
 import { MongoMeasurement } from "./mongoMeasurement";
 import native_core from "./native_core";
+import { getCodspeedRunnerMode } from "./runnerMode";
 
 declare const __VERSION__: string;
 
@@ -10,44 +11,6 @@ export const isBound = native_core.isBound;
 
 export const mongoMeasurement = new MongoMeasurement();
 
-type CodSpeedRunnerMode = "disabled" | "simulation" | "memory" | "walltime";
-
-type InstrumentMode = "disabled" | "analysis" | "walltime";
-
-export function getCodspeedRunnerMode(): CodSpeedRunnerMode {
-  const isCodSpeedEnabled = process.env.CODSPEED_ENV !== undefined;
-  if (!isCodSpeedEnabled) {
-    return "disabled";
-  }
-
-  // If CODSPEED_ENV is set, check CODSPEED_RUNNER_MODE
-  const codspeedRunnerMode = process.env.CODSPEED_RUNNER_MODE;
-  if (
-    codspeedRunnerMode === "instrumentation" ||
-    codspeedRunnerMode === "simulation"
-  ) {
-    return "simulation";
-  } else if (codspeedRunnerMode === "memory") {
-    return "memory";
-  } else if (codspeedRunnerMode === "walltime") {
-    return "walltime";
-  }
-
-  console.warn(
-    `Unknown codspeed runner mode: ${codspeedRunnerMode}, defaulting to disabled`,
-  );
-  return "disabled";
-}
-
-export function getInstrumentMode(): InstrumentMode {
-  const runnerMode = getCodspeedRunnerMode();
-  // Both "simulation" and "memory" map to "analysis" instrument mode
-  if (runnerMode === "simulation" || runnerMode === "memory") {
-    return "analysis";
-  }
-  return runnerMode; // "disabled" or "walltime"
-}
-
 export const setupCore = () => {
   if (!native_core.isBound) {
     throw new Error(
@@ -85,7 +48,8 @@ export { optimizeFunction, optimizeFunctionSync } from "./optimization";
 export { wrapWithRootFrame, wrapWithRootFrameSync } from "./rootFrame";
 export * from "./utils";
 export * from "./walltime";
-export type { InstrumentMode };
+export type { InstrumentMode } from "./runnerMode";
+export { getCodspeedRunnerMode, getInstrumentMode } from "./runnerMode";
 export const InstrumentHooks = native_core.InstrumentHooks;
 
 // Marker type constants, sourced from the native addon (which reads them from