Holy Power talent (5% holy crit) double counted

[infjitsu]

Bug description

Baseline crit chance for my toon is 15.67 but Holy Crit in ECS displays 25.67%. I've been wondering why for awhile but actually dug into today and was not able to find any other crit sources (talents, items, buffs, set bonuses) that would account for the extra 5%. Looking at the ECS code there is an API call for GetSpellCritChance(2) and then the talent Holy Power extra 5% is added to that: but the question is does the API call for GetSpellCritChance(2) already include the extra 5% crit from Holy Power? If so this is being double counted. I'm not 100% sure this is the source but raid logs do indicate my actual crit % is roughly 5% below what ECS is showing.

Screenshots

ECS/Talents

Raid line from Kara (includes extra 6% crit from Sanctified Light talent) where ECS was showing 26% holy crit with buffs/consumes (no screenshot of stats) - expected total crit of ~32%

Version

v5.3.6 - has been this way as long as I can remember though

[BreakBB]

Hey @infjitsu

Thanks for bringing this up. Blizzard is changing the API every now and then to include some talents in the base line API results, which is really hard to pin down. Can you run the following command and report the output:

/dump GetSpellCritChance(2)

If that already gives 20.67% then the talent crit is already included.

[infjitsu]

My gear changed a bit, but yes "/dump GetSpellCritChance(2)" is returning 21.97% where my crit chance in the character screen is 16.97