From 2900a6363462efb6eaab614280c7a40b89eb28d8 Mon Sep 17 00:00:00 2001 From: Joshua Simpson Date: Sun, 18 Oct 2026 06:00:14 +0000 Subject: [PATCH 1/6] Test calculator shared-query recovery on same-URL Show all --- tests/calculators-mode.dom.test.tsx | 48 +++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/tests/calculators-mode.dom.test.tsx b/tests/calculators-mode.dom.test.tsx index 15d4f504ff..ef41111246 100644 --- a/tests/calculators-mode.dom.test.tsx +++ b/tests/calculators-mode.dom.test.tsx @@ -2,6 +2,7 @@ import { fireEvent, render, screen, within } from "@testing-library/react"; import userEvent from "@testing-library/user-event"; +import { useState } from "react"; import { describe, expect, it, vi } from "vitest"; const navigation = vi.hoisted(() => ({ @@ -428,6 +429,53 @@ describe("calculator results surface", () => { ); }); + it("clears a typed shared query when Show all targets the current URL, preserving modified clicks", async () => { + const user = userEvent.setup(); + const previousUrl = window.location.href; + window.history.replaceState(null, "", "/calculators/search"); + + // Keep the provider state live: a callback spy alone would not prove that + // clearing the shared composer also restores the visible catalogue. + function SharedQueryCalculator() { + const [query, setQuery] = useState(""); + return ( + setQuery("") }}> + setQuery(event.target.value)} + /> + + + ); + } + + try { + render(); + const input = screen.getByRole("textbox", { name: "Shared calculator query" }); + await user.type(input, "PHQ-9"); + const results = screen.getByTestId("calculator-result-list"); + expect(within(results).getAllByRole("listitem")).toHaveLength(1); + expect(within(results).getByRole("button", { name: /^Open PHQ-9/ })).toBeVisible(); + const showAll = screen.getByRole("link", { name: "Show all calculators" }); + expect(showAll).toHaveAttribute("href", window.location.pathname); + + for (const modifier of [{ ctrlKey: true }, { metaKey: true }, { shiftKey: true }, { altKey: true }]) { + fireEvent.click(showAll, modifier); + expect(input).toHaveValue("PHQ-9"); + expect(within(results).getAllByRole("listitem")).toHaveLength(1); + } + + await user.click(showAll); + expect(input).toHaveValue(""); + expect(within(results).getAllByRole("listitem")).toHaveLength(calculators.length); + expect(screen.queryByTestId("calculators-show-all")).toBeNull(); + expect(window.location.pathname + window.location.search).toBe("/calculators/search"); + } finally { + window.history.replaceState(null, "", previousUrl); + } + }); + it("distinguishes filtered and query-only empty recovery", async () => { const user = userEvent.setup(); const { rerender } = render( From ed3dc82abd26be523d0d643dc7bfd1545587162e Mon Sep 17 00:00:00 2001 From: Joshua Simpson Date: Sun, 18 Oct 2026 06:05:10 +0000 Subject: [PATCH 2/6] Record audit deployment evidence and remaining device acceptance --- data/repo-awareness-snapshot.json | 32 +++++++++++++++++++ ...41f16c3f91d5a00f2df4c34e0b3223ff.record.md | 1 + ...4afc9bfd7ceffaf8a1a6b1747cd0e7af.record.md | 1 + ...54d9714fd9c08f1b5b7d9bbc07f21d22.record.md | 1 + .../audit-resolution-2026-10-17.md | 19 +++++++++++ 5 files changed, 54 insertions(+) create mode 100644 docs/branch-review-records/2c05f34aa08168b0caac1ae79287955541f16c3f91d5a00f2df4c34e0b3223ff.record.md create mode 100644 docs/branch-review-records/c170fe7a3e64c79da528e48e7c39626e4afc9bfd7ceffaf8a1a6b1747cd0e7af.record.md create mode 100644 docs/branch-review-records/cdadbdc777c94ee4285dddd1e039765c54d9714fd9c08f1b5b7d9bbc07f21d22.record.md diff --git a/data/repo-awareness-snapshot.json b/data/repo-awareness-snapshot.json index baf2a7552c..3f418e3ef6 100644 --- a/data/repo-awareness-snapshot.json +++ b/data/repo-awareness-snapshot.json @@ -6282,6 +6282,14 @@ "outcome": "PASS: closure evidence is specific and internally consistent; removed incidental ledger-row reordering", "checks": "outstanding-issues guard; Prettier; diff review; zero unresolved threads" }, + { + "date": "2026-10-17", + "ref": "HEAD", + "head": "0537cc935b86824db40ca0c117894b67638e2d95", + "scope": "PR 3628 review and fixes", + "outcome": "Found atomic worker-scope, comparator-unit, telemetry-budget, and document-source retention defects; fixes prepared with regression coverage.", + "checks": "Independent standards and specification inspection of the pinned PR diff; follow-up working-tree targeted proof 295/295 tests and 10 local SQL scenarios; hosted CI pending." + }, { "date": "2026-08-06", "ref": "claude/pr-handoff-stop-hook (PR #1649)", @@ -9146,6 +9154,14 @@ "outcome": "Pending deletion: content already on origin/main or superseded old-lineage snapshot / throwaway CI-retry branch; branch-only-file sweep found no novel work. Remote deletion DENIED (HTTP 403, session lacks ref-delete permission); branch still exists at this HEAD — operator must complete deletion. Scope is deletion-pending so future cleanup passes re-evaluate rather than skip.", "checks": "Provider-backed GitHub PR inventory via MCP (400 PRs #264-#674, all merged=false); local read-only git: rewritten-main-aware cherry-pick + two-dot tree + branch-only-file novelty sweep vs origin/main e75fad90; adversarial re-check. Remote `git push --delete` attempted (provider-backed write) and DENIED with HTTP 403. No OpenAI/Supabase/live-eval checks." }, + { + "date": "2026-10-18", + "ref": "codex/design-audit-acceptance", + "head": "2900a6363462efb6eaab614280c7a40b89eb28d8", + "scope": "Design audit acceptance follow-up", + "outcome": "Independent scoped adversarial review found no confirmed defect in the stateful calculator regression or acceptance handoff. Dedicated same-URL recovery coverage is added; production source is unchanged. Railway health verified, direct HTTP blocked by network proxy, six device/clinical acceptance checks remain explicit.", + "checks": "Owning calculator suite26passed3.62s; negative-control removal of clearQuery yields1failed25passed with PHQ-9 retained, then restored26pass. Independent static review verifies modified-click preservation and URL cleanup. Merged545treeequalsreviewed58e302. No browser/fullsuite/release/clinicaleval claimed for newtest-onlydiff." + }, { "date": "2026-07-28", "ref": "claude/navigation-pane-mockups-0600af", @@ -12642,6 +12658,14 @@ "outcome": "P2 fixed: native install prompt now avoids hero reflow, composer overlap, and prompt-induced CLS", "checks": "pwa DOM 10/10; PWA Chromium 5/5; format; exact-head merge-tree" }, + { + "date": "2026-10-18", + "ref": "main", + "head": "54559adabe5b51396c2d1c0eb395f2cf79b43fbf", + "scope": "PR 3632 landed-content verification", + "outcome": "PR was externally squash-merged during the review at 2026-10-18T05:13:46Z. Landed commit tree exactly equals reviewed head58e30257a45c0e19107b734f5ce2416eb9e6c8ad. No missing work detected. This agent did not merge, arm auto-merge, push or deploy. Manual acceptance and deployment health remain unverified.", + "checks": "Fresh origin/main54559adabe5b51396c2d1c0eb395f2cf79b43fbf has one parent; git diff --stat against reviewed head is empty; both tree hashes9e7fab3150b0448392438152c96e459d81a06c9d. Reviewed head required CI39098909136 and PR required117593597228 succeeded. No production-health or provider clinical eval invoked." + }, { "date": "2026-07-26", "ref": "PR #1246 / `codex/standardize-header-and-footer-behavior`", @@ -13066,6 +13090,14 @@ "outcome": "safe remote delete: signed-URL cache invalidation landed more strongly in merged PR #1374 with pre-publish identity clearing and extra tests; archived batch18", "checks": "current auth source/test inspection; origin/main pickaxe history; redundant cherry-pick proof; bundle verify" }, + { + "date": "2026-10-18", + "ref": "codex/design-audit-resolution", + "head": "58e30257a45c0e19107b734f5ce2416eb9e6c8ad", + "scope": "CI failure and merge-safety review", + "outcome": "No confirmed code/CI blocker. Historical failures repaired in published commits; independent scoped review found no defect. All five review threads resolved. Technically ready for owner merge; manual Safari/PWA/keyboard/AT and populated clinical-state acceptance remains unverified. No merge or push performed.", + "checks": "Hosted CI 39098909136 at exact head: PR required 117593597228 success; both coverage partitions and aggregate, all production UI shards and critical, builds, static, safety and Lighthouse success; Secret Scan and SAST success. Local audit:final-merge dry-run and git diff --check passed. No new local test suite or provider-backed clinical eval run; reused prior versioned regression evidence." + }, { "date": "2026-07-22", "ref": "PR #1075 / `codex/reconcile-route-reachability-ast`", diff --git a/docs/branch-review-records/2c05f34aa08168b0caac1ae79287955541f16c3f91d5a00f2df4c34e0b3223ff.record.md b/docs/branch-review-records/2c05f34aa08168b0caac1ae79287955541f16c3f91d5a00f2df4c34e0b3223ff.record.md new file mode 100644 index 0000000000..0eae124421 --- /dev/null +++ b/docs/branch-review-records/2c05f34aa08168b0caac1ae79287955541f16c3f91d5a00f2df4c34e0b3223ff.record.md @@ -0,0 +1 @@ +| 2026-10-18 | main | 54559adabe5b51396c2d1c0eb395f2cf79b43fbf | PR 3632 landed-content verification | PR was externally squash-merged during the review at 2026-10-18T05:13:46Z. Landed commit tree exactly equals reviewed head58e30257a45c0e19107b734f5ce2416eb9e6c8ad. No missing work detected. This agent did not merge, arm auto-merge, push or deploy. Manual acceptance and deployment health remain unverified. | Fresh origin/main54559adabe5b51396c2d1c0eb395f2cf79b43fbf has one parent; git diff --stat against reviewed head is empty; both tree hashes9e7fab3150b0448392438152c96e459d81a06c9d. Reviewed head required CI39098909136 and PR required117593597228 succeeded. No production-health or provider clinical eval invoked. | diff --git a/docs/branch-review-records/c170fe7a3e64c79da528e48e7c39626e4afc9bfd7ceffaf8a1a6b1747cd0e7af.record.md b/docs/branch-review-records/c170fe7a3e64c79da528e48e7c39626e4afc9bfd7ceffaf8a1a6b1747cd0e7af.record.md new file mode 100644 index 0000000000..a18dce142a --- /dev/null +++ b/docs/branch-review-records/c170fe7a3e64c79da528e48e7c39626e4afc9bfd7ceffaf8a1a6b1747cd0e7af.record.md @@ -0,0 +1 @@ +| 2026-10-18 | codex/design-audit-resolution | 58e30257a45c0e19107b734f5ce2416eb9e6c8ad | CI failure and merge-safety review | No confirmed code/CI blocker. Historical failures repaired in published commits; independent scoped review found no defect. All five review threads resolved. Technically ready for owner merge; manual Safari/PWA/keyboard/AT and populated clinical-state acceptance remains unverified. No merge or push performed. | Hosted CI 39098909136 at exact head: PR required 117593597228 success; both coverage partitions and aggregate, all production UI shards and critical, builds, static, safety and Lighthouse success; Secret Scan and SAST success. Local audit:final-merge dry-run and git diff --check passed. No new local test suite or provider-backed clinical eval run; reused prior versioned regression evidence. | diff --git a/docs/branch-review-records/cdadbdc777c94ee4285dddd1e039765c54d9714fd9c08f1b5b7d9bbc07f21d22.record.md b/docs/branch-review-records/cdadbdc777c94ee4285dddd1e039765c54d9714fd9c08f1b5b7d9bbc07f21d22.record.md new file mode 100644 index 0000000000..7f84166825 --- /dev/null +++ b/docs/branch-review-records/cdadbdc777c94ee4285dddd1e039765c54d9714fd9c08f1b5b7d9bbc07f21d22.record.md @@ -0,0 +1 @@ +| 2026-10-18 | codex/design-audit-acceptance | 2900a6363462efb6eaab614280c7a40b89eb28d8 | Design audit acceptance follow-up | Independent scoped adversarial review found no confirmed defect in the stateful calculator regression or acceptance handoff. Dedicated same-URL recovery coverage is added; production source is unchanged. Railway health verified, direct HTTP blocked by network proxy, six device/clinical acceptance checks remain explicit. | Owning calculator suite26passed3.62s; negative-control removal of clearQuery yields1failed25passed with PHQ-9 retained, then restored26pass. Independent static review verifies modified-click preservation and URL cleanup. Merged545treeequalsreviewed58e302. No browser/fullsuite/release/clinicaleval claimed for newtest-onlydiff. | diff --git a/docs/design-system/audit-resolution-2026-10-17.md b/docs/design-system/audit-resolution-2026-10-17.md index 60e785603b..a69bf6e088 100644 --- a/docs/design-system/audit-resolution-2026-10-17.md +++ b/docs/design-system/audit-resolution-2026-10-17.md @@ -124,3 +124,22 @@ The combined production source signature relative to base `07d4ff255` is `13ce8a After those browser checks completed, the automated Services edit received its required Prettier cleanup. An esbuild comparison confirmed it emits identical minified JavaScript before and after formatting. The resulting source signature is `729c7ec49cf24f7f2291e903e6865c91ecf0af4441884326e2130e7f81e64398`; the only source difference from the verified build is that formatting cleanup. Latest scoped lint passed, diff integrity reports **47 changed test files, 741 → 797 cases / 27 self-tests passed**, and repository-awareness freshness reports **320 pages, 638 documents, 2803 reviews**. The CI run on automated head `6c91636b2` reproduced the three now-corrected unit failures, the bot's Services formatting failure, and a Lighthouse desktop Documents-search LCP breach (1247ms against a 961ms baseline; two of three samples exceeded tolerance). The LCP element is an unchanged static paragraph; the cause is not established by that observation. The budget remains unchanged, and the follow-up head's hosted verdict is pending. + +## Acceptance follow-up — 18 October 2026 + +PR [#3632](https://github.com/BigSimmo/PsychSift/pull/3632) merged as `54559adabe5b51396c2d1c0eb395f2cf79b43fbf`. Its tree exactly matches reviewed head `58e30257a45c0e19107b734f5ce2416eb9e6c8ad`. That head passed [CI run 39098909136](https://github.com/BigSimmo/PsychSift/actions/runs/39098909136), including the authoritative `PR required` aggregate, coverage, all production Chromium shards, critical UI, builds, static checks, safety/config and Lighthouse. Secret Scan and SAST passed. This supersedes the pending publication-time statuses above; the release browser matrix was skipped. + +A dedicated stateful DOM regression now types a shared calculator query at `/calculators/search`, verifies that Show all targets the same URL, and checks that a plain click clears the composer and restores every calculator. Ctrl, Cmd, Shift and Alt clicks preserve the current query/results. The provider harness exercises the real calculator page with controlled shared state; it does not stand in for a browser test of the entire search shell. Removing the existing `clearQuery` call made this regression fail with `PHQ-9` still in the input; restoring it passed the owning 26-case suite. Production code is unchanged by this follow-up. + +Read-only Railway verification observed both production services on the audited squash commit: app deployment `766807f0-6d3b-4433-8515-9333252498fa` settled successfully at 05:46:41 UTC and worker deployment `3a40f0ee-dc5b-4f55-a51f-d9e2bb1a7d3c` at 05:36:14 UTC. Both had one running replica, zero crashed replicas, no warnings/critical notifications, no failed deployments in the preceding eight hours and no pending work. Later `62558e5c` deployments were skipped, so that revision was not live at observation. A direct anonymous `/api/health` request was blocked by the execution environment's network proxy (403); custom-domain HTTP health remains unverified. No deployment, configuration or database change was performed. + +### Remaining device and clinical acceptance + +Record the tested revision, device/OS/browser, display settings, observed result and evidence for each check. These are unobserved acceptance items, not confirmed defects; the existing clinician hold remains in force. + +- [ ] Physical iPhone Safari: navigate Modes, search Services, shortlist/compare, open and dismiss a sheet, scroll to end-of-results actions, and rotate. Confirm reachable 48px targets, no clipped controls and restored focus/context. +- [ ] Actual installed PWA: install and launch from the device home screen; repeat catalogue/search/sheet journeys. Check standalone safe-area spacing and that the dock does not hide page actions. Browser emulation does not satisfy this item. +- [ ] Real virtual keyboard: focus and type in the shared composer, open/clear filters and dismiss/reopen the keyboard. Confirm that focused fields and results/actions remain reachable without overlapping chrome. +- [ ] Assistive technology and keyboard: verify meaningful Modes names, Tab order, sheet focus containment/Escape/return, single error announcements, and Therapy zero/nonzero/interrupted-result announcements with the scenario sheet open. Record VoiceOver or TalkBack observations; DOM live-region assertions alone do not establish speech delivery. +- [ ] Zoom/reflow and contrast: inspect 200% text enlargement and 400% zoom/320 CSS-pixel reflow, light/dark themes, visible focus, disabled controls and errors. Measure applicable WCAG text and non-text contrast; do not infer compliance from token names. +- [ ] Remaining populated clinical/provider states: an authorized clinician checks the relevant real information-consuming flows against verified sources, with source status/disclosures preserved. Synthetic fixtures do not close this item; the bedside calculator remains hidden until separately verified. From a701e134e2cce25bc5e404ddd13ebcc14d2d9210 Mon Sep 17 00:00:00 2001 From: "qodo-code-review[bot]" <151058649+qodo-code-review[bot]@users.noreply.github.com> Date: Sun, 18 Oct 2026 06:10:54 +0000 Subject: [PATCH 3/6] fix: Exercise the production shared composer --- tests/calculators-mode.dom.test.tsx | 27 ++++++++++++++++++++++----- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/tests/calculators-mode.dom.test.tsx b/tests/calculators-mode.dom.test.tsx index ef41111246..64218a02ab 100644 --- a/tests/calculators-mode.dom.test.tsx +++ b/tests/calculators-mode.dom.test.tsx @@ -35,6 +35,7 @@ import { CalculatorsSearchPage } from "@/components/calculators/search-page"; import { deriveCalculator, type AnswerMap } from "@/components/calculators/calculator-ui"; import { SharedHomeEmptyState } from "@/components/clinical-dashboard/answer-status"; import { SearchCommandProvider } from "@/components/clinical-dashboard/search-command-context"; +import { MasterSearchHeader } from "@/components/clinical-dashboard/master-search-header"; import { smartSearchExpansions } from "@/lib/smart-search-intent"; // Cross-mode "also matches" panel is an AuthProvider-backed component of its own; @@ -440,10 +441,26 @@ describe("calculator results surface", () => { const [query, setQuery] = useState(""); return ( setQuery("") }}> - setQuery(event.target.value)} + undefined} + onAsk={() => undefined} + onClearQuery={() => setQuery("")} + onClearScope={() => undefined} + onQueryModeChange={() => undefined} + onScopeFiltersChange={() => undefined} + onToggleScope={() => undefined} + searchComposerVisible /> @@ -452,7 +469,7 @@ describe("calculator results surface", () => { try { render(); - const input = screen.getByRole("textbox", { name: "Shared calculator query" }); + const input = screen.getAllByTestId("global-search-input")[0]; await user.type(input, "PHQ-9"); const results = screen.getByTestId("calculator-result-list"); expect(within(results).getAllByRole("listitem")).toHaveLength(1); From 633a8b7a509b6c0863059f09f849a2ec1a58e8ba Mon Sep 17 00:00:00 2001 From: "qodo-code-review[bot]" <151058649+qodo-code-review[bot]@users.noreply.github.com> Date: Sun, 18 Oct 2026 06:10:58 +0000 Subject: [PATCH 4/6] fix: Preserve readable audit summaries --- data/repo-awareness-snapshot.json | 2 +- ...e4285dddd1e039765c54d9714fd9c08f1b5b7d9bbc07f21d22.record.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/data/repo-awareness-snapshot.json b/data/repo-awareness-snapshot.json index 3f418e3ef6..d9f64dee68 100644 --- a/data/repo-awareness-snapshot.json +++ b/data/repo-awareness-snapshot.json @@ -9160,7 +9160,7 @@ "head": "2900a6363462efb6eaab614280c7a40b89eb28d8", "scope": "Design audit acceptance follow-up", "outcome": "Independent scoped adversarial review found no confirmed defect in the stateful calculator regression or acceptance handoff. Dedicated same-URL recovery coverage is added; production source is unchanged. Railway health verified, direct HTTP blocked by network proxy, six device/clinical acceptance checks remain explicit.", - "checks": "Owning calculator suite26passed3.62s; negative-control removal of clearQuery yields1failed25passed with PHQ-9 retained, then restored26pass. Independent static review verifies modified-click preservation and URL cleanup. Merged545treeequalsreviewed58e302. No browser/fullsuite/release/clinicaleval claimed for newtest-onlydiff." + "checks": "Owning calculator suite: 26 passed (3.62s); negative-control removal of clearQuery yields 1 failed, 25 passed with PHQ-9 retained, then restored 26 passed. Independent static review verifies modified-click preservation and URL cleanup. Merged 545 tree equals reviewed 58e302. No browser/fullsuite/release/clinicaleval claimed for new test-only diff." }, { "date": "2026-07-28", diff --git a/docs/branch-review-records/cdadbdc777c94ee4285dddd1e039765c54d9714fd9c08f1b5b7d9bbc07f21d22.record.md b/docs/branch-review-records/cdadbdc777c94ee4285dddd1e039765c54d9714fd9c08f1b5b7d9bbc07f21d22.record.md index 7f84166825..5650f7eae9 100644 --- a/docs/branch-review-records/cdadbdc777c94ee4285dddd1e039765c54d9714fd9c08f1b5b7d9bbc07f21d22.record.md +++ b/docs/branch-review-records/cdadbdc777c94ee4285dddd1e039765c54d9714fd9c08f1b5b7d9bbc07f21d22.record.md @@ -1 +1 @@ -| 2026-10-18 | codex/design-audit-acceptance | 2900a6363462efb6eaab614280c7a40b89eb28d8 | Design audit acceptance follow-up | Independent scoped adversarial review found no confirmed defect in the stateful calculator regression or acceptance handoff. Dedicated same-URL recovery coverage is added; production source is unchanged. Railway health verified, direct HTTP blocked by network proxy, six device/clinical acceptance checks remain explicit. | Owning calculator suite26passed3.62s; negative-control removal of clearQuery yields1failed25passed with PHQ-9 retained, then restored26pass. Independent static review verifies modified-click preservation and URL cleanup. Merged545treeequalsreviewed58e302. No browser/fullsuite/release/clinicaleval claimed for newtest-onlydiff. | +| 2026-10-18 | codex/design-audit-acceptance | 2900a6363462efb6eaab614280c7a40b89eb28d8 | Design audit acceptance follow-up | Independent scoped adversarial review found no confirmed defect in the stateful calculator regression or acceptance handoff. Dedicated same-URL recovery coverage is added; production source is unchanged. Railway health verified, direct HTTP blocked by network proxy, six device/clinical acceptance checks remain explicit. | Owning calculator suite: 26 passed (3.62s); negative-control removal of clearQuery yields 1 failed, 25 passed with PHQ-9 retained, then restored 26 passed. Independent static review verifies modified-click preservation and URL cleanup. Merged 545 tree equals reviewed 58e302. No browser/fullsuite/release/clinicaleval claimed for new test-only diff. | From 415f84aae6805bb82ae150b8df7fae55d55ca5cd Mon Sep 17 00:00:00 2001 From: Joshua Simpson Date: Sun, 18 Oct 2026 06:15:08 +0000 Subject: [PATCH 5/6] Restore scoped calculator regression and preserve immutable review evidence --- data/repo-awareness-snapshot.json | 10 +++++- ...54d9714fd9c08f1b5b7d9bbc07f21d22.record.md | 2 +- ...e7baecc818190ef9e5b875b6087d43f5.record.md | 1 + tests/calculators-mode.dom.test.tsx | 33 +++++-------------- 4 files changed, 19 insertions(+), 27 deletions(-) create mode 100644 docs/branch-review-records/e3261b4213a536fc48f788e20f3bd7a7e7baecc818190ef9e5b875b6087d43f5.record.md diff --git a/data/repo-awareness-snapshot.json b/data/repo-awareness-snapshot.json index d9f64dee68..515351a1f3 100644 --- a/data/repo-awareness-snapshot.json +++ b/data/repo-awareness-snapshot.json @@ -9160,7 +9160,7 @@ "head": "2900a6363462efb6eaab614280c7a40b89eb28d8", "scope": "Design audit acceptance follow-up", "outcome": "Independent scoped adversarial review found no confirmed defect in the stateful calculator regression or acceptance handoff. Dedicated same-URL recovery coverage is added; production source is unchanged. Railway health verified, direct HTTP blocked by network proxy, six device/clinical acceptance checks remain explicit.", - "checks": "Owning calculator suite: 26 passed (3.62s); negative-control removal of clearQuery yields 1 failed, 25 passed with PHQ-9 retained, then restored 26 passed. Independent static review verifies modified-click preservation and URL cleanup. Merged 545 tree equals reviewed 58e302. No browser/fullsuite/release/clinicaleval claimed for new test-only diff." + "checks": "Owning calculator suite26passed3.62s; negative-control removal of clearQuery yields1failed25passed with PHQ-9 retained, then restored26pass. Independent static review verifies modified-click preservation and URL cleanup. Merged545treeequalsreviewed58e302. No browser/fullsuite/release/clinicaleval claimed for newtest-onlydiff." }, { "date": "2026-07-28", @@ -14042,6 +14042,14 @@ "outcome": "before: CONFLICTING + PR policy FAIL + unresolved Codex P1 (conflict markers in answer/route.ts). after: conflict markers removed and pushed (80212dd91, 632e84c94); merge origin/main aborted (non-trivial conflicts: privacy/page.tsx, answer-render-policy.ts, source-authority-metadata.ts, upload/route.ts, supabase/drift-manifest.json, settings-dialog, validation/answer-request, plus UI/docs/tests); PR policy still FAIL (Clinical Governance Preflight missing — body edit forbidden this sweep); thread reply/resolve needs parent (comment 3644028277 / thread PRRT_kwDOSh5Fis6Tfkev) — ManagePullRequest/GitHub write MCP unavailable", "checks": "typecheck:internal pass; vitest clinical-dashboard-merge-artifacts + visual-evidence-tabs pass (9); no provider-backed checks run" }, + { + "date": "2026-10-18", + "ref": "codex/design-audit-acceptance", + "head": "633a8b7a509b6c0863059f09f849a2ec1a58e8ba", + "scope": "Automated acceptance follow-up review", + "outcome": "Two confirmed automated-edit issues: a missing usePathname mock prevents the new header fixture from rendering, and an already published immutable review was rewritten. Restore the scoped page/provider harness and original record bytes. The test name explicitly limits its contract; no production shell or physical-device coverage is claimed. Corrections verified locally; publication pending.", + "checks": "Independent source review and local reproduction: 1 failed, 25 passed at bot head, missing next/navigation usePathname export. Corrected owning suite: 26 passed. Original regression negative control: removing clearQuery left PHQ-9 in the input. Original immutable record restored byte-for-byte against ed3dc82abd26be523d0d643dc7bfd1545587162e. Production source unchanged." + }, { "date": "2026-07-13", "ref": "claude/scroll-icon-design-8b7675", diff --git a/docs/branch-review-records/cdadbdc777c94ee4285dddd1e039765c54d9714fd9c08f1b5b7d9bbc07f21d22.record.md b/docs/branch-review-records/cdadbdc777c94ee4285dddd1e039765c54d9714fd9c08f1b5b7d9bbc07f21d22.record.md index 5650f7eae9..7f84166825 100644 --- a/docs/branch-review-records/cdadbdc777c94ee4285dddd1e039765c54d9714fd9c08f1b5b7d9bbc07f21d22.record.md +++ b/docs/branch-review-records/cdadbdc777c94ee4285dddd1e039765c54d9714fd9c08f1b5b7d9bbc07f21d22.record.md @@ -1 +1 @@ -| 2026-10-18 | codex/design-audit-acceptance | 2900a6363462efb6eaab614280c7a40b89eb28d8 | Design audit acceptance follow-up | Independent scoped adversarial review found no confirmed defect in the stateful calculator regression or acceptance handoff. Dedicated same-URL recovery coverage is added; production source is unchanged. Railway health verified, direct HTTP blocked by network proxy, six device/clinical acceptance checks remain explicit. | Owning calculator suite: 26 passed (3.62s); negative-control removal of clearQuery yields 1 failed, 25 passed with PHQ-9 retained, then restored 26 passed. Independent static review verifies modified-click preservation and URL cleanup. Merged 545 tree equals reviewed 58e302. No browser/fullsuite/release/clinicaleval claimed for new test-only diff. | +| 2026-10-18 | codex/design-audit-acceptance | 2900a6363462efb6eaab614280c7a40b89eb28d8 | Design audit acceptance follow-up | Independent scoped adversarial review found no confirmed defect in the stateful calculator regression or acceptance handoff. Dedicated same-URL recovery coverage is added; production source is unchanged. Railway health verified, direct HTTP blocked by network proxy, six device/clinical acceptance checks remain explicit. | Owning calculator suite26passed3.62s; negative-control removal of clearQuery yields1failed25passed with PHQ-9 retained, then restored26pass. Independent static review verifies modified-click preservation and URL cleanup. Merged545treeequalsreviewed58e302. No browser/fullsuite/release/clinicaleval claimed for newtest-onlydiff. | diff --git a/docs/branch-review-records/e3261b4213a536fc48f788e20f3bd7a7e7baecc818190ef9e5b875b6087d43f5.record.md b/docs/branch-review-records/e3261b4213a536fc48f788e20f3bd7a7e7baecc818190ef9e5b875b6087d43f5.record.md new file mode 100644 index 0000000000..f29784b310 --- /dev/null +++ b/docs/branch-review-records/e3261b4213a536fc48f788e20f3bd7a7e7baecc818190ef9e5b875b6087d43f5.record.md @@ -0,0 +1 @@ +| 2026-10-18 | codex/design-audit-acceptance | 633a8b7a509b6c0863059f09f849a2ec1a58e8ba | Automated acceptance follow-up review | Two confirmed automated-edit issues: a missing usePathname mock prevents the new header fixture from rendering, and an already published immutable review was rewritten. Restore the scoped page/provider harness and original record bytes. The test name explicitly limits its contract; no production shell or physical-device coverage is claimed. Corrections verified locally; publication pending. | Independent source review and local reproduction: 1 failed, 25 passed at bot head, missing next/navigation usePathname export. Corrected owning suite: 26 passed. Original regression negative control: removing clearQuery left PHQ-9 in the input. Original immutable record restored byte-for-byte against ed3dc82abd26be523d0d643dc7bfd1545587162e. Production source unchanged. | diff --git a/tests/calculators-mode.dom.test.tsx b/tests/calculators-mode.dom.test.tsx index 64218a02ab..da45861cb0 100644 --- a/tests/calculators-mode.dom.test.tsx +++ b/tests/calculators-mode.dom.test.tsx @@ -35,7 +35,6 @@ import { CalculatorsSearchPage } from "@/components/calculators/search-page"; import { deriveCalculator, type AnswerMap } from "@/components/calculators/calculator-ui"; import { SharedHomeEmptyState } from "@/components/clinical-dashboard/answer-status"; import { SearchCommandProvider } from "@/components/clinical-dashboard/search-command-context"; -import { MasterSearchHeader } from "@/components/clinical-dashboard/master-search-header"; import { smartSearchExpansions } from "@/lib/smart-search-intent"; // Cross-mode "also matches" panel is an AuthProvider-backed component of its own; @@ -430,37 +429,21 @@ describe("calculator results surface", () => { ); }); - it("clears a typed shared query when Show all targets the current URL, preserving modified clicks", async () => { + it("clears the page's shared-query provider on same-URL Show all, preserving modified clicks", async () => { const user = userEvent.setup(); const previousUrl = window.location.href; window.history.replaceState(null, "", "/calculators/search"); // Keep the provider state live: a callback spy alone would not prove that // clearing the shared composer also restores the visible catalogue. - function SharedQueryCalculator() { + function CalculatorPageProviderHarness() { const [query, setQuery] = useState(""); return ( setQuery("") }}> - undefined} - onAsk={() => undefined} - onClearQuery={() => setQuery("")} - onClearScope={() => undefined} - onQueryModeChange={() => undefined} - onScopeFiltersChange={() => undefined} - onToggleScope={() => undefined} - searchComposerVisible + setQuery(event.target.value)} /> @@ -468,8 +451,8 @@ describe("calculator results surface", () => { } try { - render(); - const input = screen.getAllByTestId("global-search-input")[0]; + render(); + const input = screen.getByRole("textbox", { name: "Shared calculator query" }); await user.type(input, "PHQ-9"); const results = screen.getByTestId("calculator-result-list"); expect(within(results).getAllByRole("listitem")).toHaveLength(1); From 972deb9d8a036579072008083a058f286489c22e Mon Sep 17 00:00:00 2001 From: BigSimmo Date: Sun, 18 Oct 2026 14:48:18 +0800 Subject: [PATCH 6/6] Supersede acceptance review record: Railway deployment status verified, public HTTP health unverified --- data/repo-awareness-snapshot.json | 8 ++++++++ ...b7d9462fa0126769cbf78d566bdff78f8e468bce23d0.record.md | 1 + 2 files changed, 9 insertions(+) create mode 100644 docs/branch-review-records/0f870b9af5a6c1a2295cb7d9462fa0126769cbf78d566bdff78f8e468bce23d0.record.md diff --git a/data/repo-awareness-snapshot.json b/data/repo-awareness-snapshot.json index 515351a1f3..74bc3d2477 100644 --- a/data/repo-awareness-snapshot.json +++ b/data/repo-awareness-snapshot.json @@ -9162,6 +9162,14 @@ "outcome": "Independent scoped adversarial review found no confirmed defect in the stateful calculator regression or acceptance handoff. Dedicated same-URL recovery coverage is added; production source is unchanged. Railway health verified, direct HTTP blocked by network proxy, six device/clinical acceptance checks remain explicit.", "checks": "Owning calculator suite26passed3.62s; negative-control removal of clearQuery yields1failed25passed with PHQ-9 retained, then restored26pass. Independent static review verifies modified-click preservation and URL cleanup. Merged545treeequalsreviewed58e302. No browser/fullsuite/release/clinicaleval claimed for newtest-onlydiff." }, + { + "date": "2026-10-18", + "ref": "codex/design-audit-acceptance", + "head": "2900a6363462efb6eaab614280c7a40b89eb28d8", + "scope": "Design audit acceptance follow-up (supersedes 2026-10-18)", + "outcome": "Wording correction only (CodeRabbit). Railway deployment status was verified; public HTTP health remains unverified because direct HTTP was blocked by the network proxy. Otherwise unchanged: independent scoped adversarial review found no confirmed defect in the stateful calculator regression or acceptance handoff; dedicated same-URL recovery coverage is added; production source is unchanged; six device/clinical acceptance checks remain explicit.", + "checks": "No new checks: restates the superseded record's evidence (owning calculator suite 26 passed; negative-control removal of clearQuery 1 failed 25 passed, restored 26 passed; static review of modified-click preservation and URL cleanup). No public HTTP health, browser, full-suite, release or clinical eval claimed." + }, { "date": "2026-07-28", "ref": "claude/navigation-pane-mockups-0600af", diff --git a/docs/branch-review-records/0f870b9af5a6c1a2295cb7d9462fa0126769cbf78d566bdff78f8e468bce23d0.record.md b/docs/branch-review-records/0f870b9af5a6c1a2295cb7d9462fa0126769cbf78d566bdff78f8e468bce23d0.record.md new file mode 100644 index 0000000000..72ee090880 --- /dev/null +++ b/docs/branch-review-records/0f870b9af5a6c1a2295cb7d9462fa0126769cbf78d566bdff78f8e468bce23d0.record.md @@ -0,0 +1 @@ +| 2026-10-18 | codex/design-audit-acceptance | 2900a6363462efb6eaab614280c7a40b89eb28d8 | Design audit acceptance follow-up (supersedes 2026-10-18) | Wording correction only (CodeRabbit). Railway deployment status was verified; public HTTP health remains unverified because direct HTTP was blocked by the network proxy. Otherwise unchanged: independent scoped adversarial review found no confirmed defect in the stateful calculator regression or acceptance handoff; dedicated same-URL recovery coverage is added; production source is unchanged; six device/clinical acceptance checks remain explicit. | No new checks: restates the superseded record's evidence (owning calculator suite 26 passed; negative-control removal of clearQuery 1 failed 25 passed, restored 26 passed; static review of modified-click preservation and URL cleanup). No public HTTP health, browser, full-suite, release or clinical eval claimed. |