From 190838f5d276546c844b0626bfcff7dc7c2ff824 Mon Sep 17 00:00:00 2001 From: Seun Akanni Date: Tue, 29 Sep 2026 16:32:38 +0100 Subject: [PATCH] chore(ci-compliance): use public fixture names in the upgrade-map tests Three fixtures and one comment added in #23 named private repositories: a comment naming a private repository's upgrade map, and two test cases under a private repository's oM project directory. Each name is a literal project directory in a repository that is private, so a path search on it returns that repository alone. Substituted for BHoM_Datasets, which has the layout the comment describes and is public, and Structure_oM, which is public and already used two lines below in the same block. The assertions are unchanged in shape and count: these paths carry no "datasets" substring, so they exercise the upgrade-map predicate on its own exactly as before. 88 unit tests and 66 integration tests pass, unchanged from before the substitution. --- .../Compliance.Unit.Tests/Unit/FileFilterTests.cs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/ComplianceRunner/tests/Compliance.Unit.Tests/Unit/FileFilterTests.cs b/tools/ComplianceRunner/tests/Compliance.Unit.Tests/Unit/FileFilterTests.cs index 9e47289..18b4128 100644 --- a/tools/ComplianceRunner/tests/Compliance.Unit.Tests/Unit/FileFilterTests.cs +++ b/tools/ComplianceRunner/tests/Compliance.Unit.Tests/Unit/FileFilterTests.cs @@ -41,9 +41,9 @@ public class IsDatasetFileTests [TestCase("DataSets/foo.json", ExpectedResult = true)] // root-level, mixed case [TestCase("DataSets/LCA/deep/x.json", ExpectedResult = true)] // root-level, nested - // Versioning upgrade maps. The live case is a project directory supplying the - // "datasets" substring, which is how BuroHappold_Datasets/Versioning_93.json and - // BHoM_Datasets/Versioning_100.json get selected at all. + // Versioning upgrade maps. A project directory supplying the "datasets" substring is + // the only way a file named like this is selected at all, and BHoM_Datasets has that + // layout: one .csproj in a directory whose name carries the substring. [TestCase("BHoM_Datasets/Versioning_93.json", ExpectedResult = false)] [TestCase("BHoM_Datasets/Versioning_100.json", ExpectedResult = false)] [TestCase(@"BHoM_Datasets\Versioning_93.json", ExpectedResult = false)] // backslash separators @@ -77,8 +77,8 @@ public bool IsDatasetFile(string file) // The upgrade-map rule on its own, so a failure says which of the two predicates moved. // These paths carry no "datasets" substring, so IsDatasetFile rejects them anyway and // could not distinguish the two. - [TestCase("Tagging_oM/Versioning_93.json", ExpectedResult = true)] - [TestCase("Tagging_oM/Versioning_Rules.json", ExpectedResult = false)] + [TestCase("Structure_oM/Versioning_93.json", ExpectedResult = true)] + [TestCase("Structure_oM/Versioning_Rules.json", ExpectedResult = false)] [TestCase("Versioning_93.json", ExpectedResult = true)] // no directory at all [TestCase("Structure_oM/Versioning_93.txt", ExpectedResult = true)] // extension is IsDatasetFile's job public bool IsVersioningUpgradeMap(string file)