Skip to content

Add client settings constructor, deprecate old constructors #41

@cjmang

Description

@cjmang

The current client takes in configuration parameters directly via the constructor. The issue with this approach is there are a bunch of settings you need to toggle after creating the object, and there are also a bunch of settings that we will probably want to add when constructing the object. The Client class should be updated to take in a ClientSettings object, which should be immutable. The ClientSettings object should be constructed using a ClientSettingsBuilder, which consumers should use and configure before creating a Client. This will provide extensibility without needing to repeatedly add/update the constructors.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions