From b4ae3503c75aaf5cecf5d81bbe57e32b801e62f0 Mon Sep 17 00:00:00 2001
From: CarlosFelipeOR <carlosfelipeor@gmail.com>
Date: Thu, 21 May 2026 21:27:41 -0300
Subject: [PATCH 1/3] Fix /play download popover keyboard focus behavior

Signed-off-by: CarlosFelipeOR <carlosfelipeor@gmail.com>
---
 programs/server/play.html | 41 +++++++++++++++++++++++++++++++++++++--
 1 file changed, 39 insertions(+), 2 deletions(-)

diff --git a/programs/server/play.html b/programs/server/play.html
index bdc4c3217765..afc036e3f937 100644
--- a/programs/server/play.html
+++ b/programs/server/play.html
@@ -723,7 +723,7 @@
             </a>
             <a id="cloud-logo" href="https://altinity.cloud/">&#9729;</a>
         </p>
-        <div id="download-dropdown">
+        <div id="download-dropdown" role="dialog" aria-label="Download query result">
             <div>
                 <div class="download-option">
                     <label for="download-format">Format:</label>
@@ -2969,6 +2969,8 @@
 
         dropdown.style.top = (button_rect.top - context_rect.top) + 'px';
         dropdown.style.left = (button_rect.left - context_rect.left + button_rect.width - dropdown_rect.width) + 'px';
+
+        document.getElementById('download-format').focus();
     }
 });
 
@@ -2977,10 +2979,44 @@
     e.stopPropagation();
 });
 
+// Keyboard handling inside the download dialog: focus trap + Escape to close
+document.getElementById('download-dropdown').addEventListener('keydown', function(e) {
+    const dropdown = document.getElementById('download-dropdown');
+    if (!dropdown.classList.contains('show')) return;
+
+    if (e.key === 'Escape') {
+        e.preventDefault();
+        dropdown.classList.remove('show');
+        document.getElementById('download-div').focus();
+        return;
+    }
+
+    if (e.key === 'Tab') {
+        const focusable = dropdown.querySelectorAll(
+            'select, input:not([type=hidden]), button, [tabindex]:not([tabindex="-1"])'
+        );
+        const visible = Array.from(focusable).filter(el => el.offsetParent !== null);
+        if (visible.length === 0) return;
+
+        const first = visible[0];
+        const last = visible[visible.length - 1];
+
+        if (e.shiftKey && document.activeElement === first) {
+            e.preventDefault();
+            last.focus();
+        } else if (!e.shiftKey && document.activeElement === last) {
+            e.preventDefault();
+            first.focus();
+        }
+    }
+});
+
 // Close dropdown when clicking outside
 document.addEventListener('click', function() {
     const dropdown = document.getElementById('download-dropdown');
-    dropdown.classList.remove('show');
+    if (dropdown.classList.contains('show')) {
+        dropdown.classList.remove('show');
+    }
 });
 
 // Handle "Other" format selection
@@ -3051,6 +3087,7 @@
 
     // Close dropdown
     document.getElementById('download-dropdown').classList.remove('show');
+    document.getElementById('download-div').focus();
 });
 </script>
 </html>

From 908252aca0fe23f751692f2dfee0a1068c085dcd Mon Sep 17 00:00:00 2001
From: CarlosFelipeOR <carlosfelipeor@gmail.com>
Date: Fri, 22 May 2026 09:54:43 -0300
Subject: [PATCH 2/3] Add visible keyboard focus indicators for /play Download
 popover controls

Signed-off-by: CarlosFelipeOR <carlosfelipeor@gmail.com>
---
 programs/server/play.html | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/programs/server/play.html b/programs/server/play.html
index afc036e3f937..c6c5f432ddea 100644
--- a/programs/server/play.html
+++ b/programs/server/play.html
@@ -563,6 +563,16 @@
             }
         }
 
+        /* Show keyboard focus clearly for download controls. */
+        #download-div:focus-visible,
+        #download-format:focus-visible,
+        #download-format-other:focus-visible,
+        #download-button:focus-visible
+        {
+            outline: 2px solid var(--border-color-selected);
+            outline-offset: 2px;
+        }
+
         #theme
         {
             grid-area: theme;

From ba05abdbea5701fdb402a499540db1eab8a2c6c3 Mon Sep 17 00:00:00 2001
From: CarlosFelipeOR <carlosfelipeor@gmail.com>
Date: Fri, 22 May 2026 19:54:15 -0300
Subject: [PATCH 3/3] Keep focus outline only inside /play Download popover

Signed-off-by: CarlosFelipeOR <carlosfelipeor@gmail.com>
---
 programs/server/play.html | 1 -
 1 file changed, 1 deletion(-)

diff --git a/programs/server/play.html b/programs/server/play.html
index c6c5f432ddea..d4c7adaacdcd 100644
--- a/programs/server/play.html
+++ b/programs/server/play.html
@@ -564,7 +564,6 @@
         }
 
         /* Show keyboard focus clearly for download controls. */
-        #download-div:focus-visible,
         #download-format:focus-visible,
         #download-format-other:focus-visible,
         #download-button:focus-visible